linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <galpress@amazon.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Doug Ledford <dledford@redhat.com>,
	linux-rdma@vger.kernel.org,
	Alexander Matushevsky <matua@amazon.com>,
	Firas JahJah <firasj@amazon.com>, Guy Tzalik <gtzalik@amazon.com>
Subject: Re: [PATCH for-next 2/2] RDMA/efa: Report host information to the device
Date: Mon, 11 May 2020 19:34:56 +0300	[thread overview]
Message-ID: <20200511163456.GC356445@unreal> (raw)
In-Reply-To: <2f15e2fb-22d2-2d8e-50f0-9fa7964f7104@amazon.com>

On Mon, May 11, 2020 at 03:47:57PM +0300, Gal Pressman wrote:
> On 10/05/2020 18:16, Leon Romanovsky wrote:
> > On Sun, May 10, 2020 at 04:05:45PM +0300, Gal Pressman wrote:
> >> On 10/05/2020 15:29, Leon Romanovsky wrote:
> >>> On Sun, May 10, 2020 at 02:59:18PM +0300, Gal Pressman wrote:
> >>>> diff --git a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> >>>> index 96b104ab5415..efdeebc9ea9b 100644
> >>>> --- a/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> >>>> +++ b/drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
> >>>> @@ -37,7 +37,7 @@ enum efa_admin_aq_feature_id {
> >>>>  	EFA_ADMIN_NETWORK_ATTR                      = 3,
> >>>>  	EFA_ADMIN_QUEUE_ATTR                        = 4,
> >>>>  	EFA_ADMIN_HW_HINTS                          = 5,
> >>>> -	EFA_ADMIN_FEATURES_OPCODE_NUM               = 8,
> >>>> +	EFA_ADMIN_HOST_INFO                         = 6,
> >>>>  };
> >>>>
> >>>>  /* QP transport type */
> >>>> @@ -799,6 +799,55 @@ struct efa_admin_mmio_req_read_less_resp {
> >>>>  	u32 reg_val;
> >>>>  };
> >>>>
> >>>> +enum efa_admin_os_type {
> >>>> +	EFA_ADMIN_OS_LINUX                          = 0,
> >>>> +	EFA_ADMIN_OS_WINDOWS                        = 1,
> >>>
> >>> Not used.
> >>
> >> That's the device interface..
> >
> > It doesn't matter, we don't add code/defines that are not in use.
>
> First of all, that's not true, look at mlx5 device spec for example.
> It's 10k lines long and has many unused values..

Patch that removes that crap is more than welcomed.

>
> I don't think we should go as far as commits like 1759d322f4ba ("net/mlx5: Add
> hardware definitions for sub functions") which adds new commands interface
> without implementing it (nor does any following patch), but exposing the related
> bits directly in the scope of the feature that's being introduced is different.

It is not on my watch and feel free to NAK any patch that tries to do the same.

>
> The driver version fields that you don't like are going to stay there as they're
> the device ABI, and IMHO "hiding" them as reserved has zero upsides and won't
> change the fact that they're unused.

Our views are different.

Thanks

  reply	other threads:[~2020-05-11 16:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 11:59 [PATCH for-next 0/2] EFA host information Gal Pressman
2020-05-10 11:59 ` [PATCH for-next 1/2] RDMA/efa: Fix setting of wrong bit in get/set_feature commands Gal Pressman
2020-05-10 11:59 ` [PATCH for-next 2/2] RDMA/efa: Report host information to the device Gal Pressman
2020-05-10 12:29   ` Leon Romanovsky
2020-05-10 13:05     ` Gal Pressman
2020-05-10 15:16       ` Leon Romanovsky
2020-05-11 12:47         ` Gal Pressman
2020-05-11 16:34           ` Leon Romanovsky [this message]
2020-05-10 13:42   ` kbuild test robot
2020-05-10 14:40     ` Gal Pressman
2020-05-10 15:11       ` Leon Romanovsky
2020-05-11 12:40         ` Gal Pressman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511163456.GC356445@unreal \
    --to=leon@kernel.org \
    --cc=dledford@redhat.com \
    --cc=firasj@amazon.com \
    --cc=galpress@amazon.com \
    --cc=gtzalik@amazon.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).