From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA04C2D0FA for ; Wed, 13 May 2020 12:51:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47E26206CC for ; Wed, 13 May 2020 12:51:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="m6ad7mNk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732006AbgEMMvs (ORCPT ); Wed, 13 May 2020 08:51:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731779AbgEMMvr (ORCPT ); Wed, 13 May 2020 08:51:47 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BFFAC05BD09 for ; Wed, 13 May 2020 05:51:46 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id z80so11601443qka.0 for ; Wed, 13 May 2020 05:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=I21hL7AkwUgdNPUI4l7KTQwvXQoa/NOyWUo4IiS5Zaw=; b=m6ad7mNkFXWQP2LAar13cizth8P3iKliOem15ctBmD+RRB5NWWGZ4hVFaLb43OUHF4 dEfbKyHnbdTPvph0NO3q6QQG3feEsDR1NN/aDJiylAVOx6elqA7EySRBy4zgPJs7Fz0/ Wh3NuXdccvtT3AKlZIUnJi/oe7DjFVTOpq20lvPm5ktnPdoP012Lk/9j/pUDGJCnQSsG TmFagaUtz3vbm20kiJmFo0AhIIm3asYdCe/QXnsQdcQLCh91UXycsxj5M4FwgjK5Th4v OuuA5GD8cz9mUhRoZ9e54BvWpbbFTnY1KxAJWQ9Fh7pEfNmqL/JrbXuEeLjTtGaJiHKf PtmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=I21hL7AkwUgdNPUI4l7KTQwvXQoa/NOyWUo4IiS5Zaw=; b=ob8RIeWLx9/naSGVRmwnre1sEcgCYA+Zw9IVtDj9ARfB9zYsHeUnWRRYUxEkdzHzf/ SZL3jlLDqEA8P41SVdTV5b2ecOU700yrsinpQZpM+uiCTvelLSEk62bH+mst4lr0HOV8 4snOCWR8KZvSjAm8/YFegzKXIKHkMR3nr3xDqXiDMTXvFjkfXKFug/SnAXOHSV15DgZ1 8AN7QCcZFG/UoJ5OwTAzHrtMz1q1+b8z+RWxDQGltKKqA8FdubSMgNBC3LY6H6LWHnFK +QbMo2oT7CcTAjdANQVZSlTQO39OmywNC5euOt37fFXFCpg2cwVdITPDn8elmEURtnbc 5dAA== X-Gm-Message-State: AGi0PuaPM3qmM//StCq6DOYQ8ILEPk4G0xNgYfOm/GvAiCcDM+6CCMKQ pubNMIsDocBz+DUV65m/6yoOKw== X-Google-Smtp-Source: APiQypKy6izjhUbivG+/I6PWV8eR0peu4dabx2HIoItXGvYLmzKEIJJmSlJIMmuJWfJIdDxUx9gC8w== X-Received: by 2002:a37:61d8:: with SMTP id v207mr26564281qkb.146.1589374305465; Wed, 13 May 2020 05:51:45 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id t67sm13779002qka.17.2020.05.13.05.51.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 May 2020 05:51:44 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jYqrQ-0008K6-D9; Wed, 13 May 2020 09:51:44 -0300 Date: Wed, 13 May 2020 09:51:44 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: "David S. Miller" , Jakub Kicinski , Eric Dumazet , Alexey Kuznetsov , Hideaki YOSHIFUJI , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , Jon Maloy , Ying Xue , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 11/33] tcp: tcp_sock_set_nodelay Message-ID: <20200513125144.GC29989@ziepe.ca> References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513062649.2100053-12-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, May 13, 2020 at 08:26:26AM +0200, Christoph Hellwig wrote: > Add a helper to directly set the TCP_NODELAY sockopt from kernel space > without going through a fake uaccess. Cleanup the callers to avoid > pointless wrappers now that this is a simple function call. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/drbd/drbd_int.h | 7 ---- > drivers/block/drbd/drbd_main.c | 2 +- > drivers/block/drbd/drbd_receiver.c | 4 +-- > drivers/infiniband/sw/siw/siw_cm.c | 24 +++----------- > drivers/nvme/host/tcp.c | 9 +----- > drivers/nvme/target/tcp.c | 12 ++----- > drivers/target/iscsi/iscsi_target_login.c | 15 ++------- > fs/cifs/connect.c | 10 ++---- > fs/dlm/lowcomms.c | 8 ++--- > fs/ocfs2/cluster/tcp.c | 20 ++---------- > include/linux/tcp.h | 1 + > net/ceph/messenger.c | 11 ++----- > net/ipv4/tcp.c | 39 +++++++++++++++-------- > net/rds/tcp.c | 11 +------ > net/rds/tcp.h | 1 - > net/rds/tcp_listen.c | 2 +- > 16 files changed, 49 insertions(+), 127 deletions(-) No problem with the siw change Acked-by: Jason Gunthorpe Jason