From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D0BEC433DF for ; Wed, 20 May 2020 00:00:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B62620842 for ; Wed, 20 May 2020 00:00:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AtrAp4V4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbgETAA6 (ORCPT ); Tue, 19 May 2020 20:00:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbgETAA6 (ORCPT ); Tue, 19 May 2020 20:00:58 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E13C061A0E for ; Tue, 19 May 2020 17:00:56 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id z5so540228qvw.4 for ; Tue, 19 May 2020 17:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oE/Ah52jSj0agjmvQ8lX4jPK/RfpHlM8F3+a9KJkLyM=; b=AtrAp4V4qyOMONdlg7yRBoQGQWCUt4QrrpXDcsQOdpeUxxg0bCzO9iESHoIRmne6if YYpjY8HKK84DltVXZsMXrc43PN6BcSNfsyiTQwVsDE6cCFzhjuGcxyBl5ds70FyR3D6k A2Tutwopig3567YOXAp4WK0+ILjvmHMPM7JjRh0Ia8JGZlRTVBisEDPVOgSaUQQGFuVN vA9DSJJ/pOhQyx9SrI4NpketeK1V+OlHah7Ens6SJ/3faQyS92WDYdCD2gpWAAX4ugjf pQFtt+CxrqzCAw7uculMWzOKUwu0pt2sjfkFP5NfAFcyIfXzxsmhYJYpUx6jw+KMCyEd XlRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oE/Ah52jSj0agjmvQ8lX4jPK/RfpHlM8F3+a9KJkLyM=; b=RxARjVlvM2RHAyFi7rAcPWp4joqMpadP70I8TCdSNqTdBeQHTCiM6IyczJvmiMLkD6 zGOlEZhQbqvqquaHrcB9xIc5/ecIeYSr0wnymjsD6BTRQmWFw5PZTCyDgfm5I1Y1DygW mzfknWnD70qU8dQNSUCTSE/9hwyTTVKrNDLMjZJcy2aHoCOotlmPGEdGhYcdepXwrbaD 060jjvevbqlS58CuJXpwOp9ILLvvudxRj7gAeRWfgGHJPHAQuTWdDWMULa6QrHSzRU4A 6SnqyQEGq80LzkkaKyW25a5D9MqS7uuZ2EbMpdJdax/S7hNlNRXrRxDkh3qryTqBCq/7 8rNQ== X-Gm-Message-State: AOAM533kB8+P3y8j1H/xeFTQKL35b0eWMVDLnJGlDy8wpPo6qSZ9vGrN /EXATamA66MfqM6IFiFewcfR6A== X-Google-Smtp-Source: ABdhPJwkUTtWCGAwdWtVD4Pfac9u33ckw7vmZLGT2Qm6/Epr8GWHFVGiFFpkqYOmLHgZGnBG6kf+Qw== X-Received: by 2002:a0c:a5c5:: with SMTP id z63mr2362035qvz.50.1589932856167; Tue, 19 May 2020 17:00:56 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id t130sm939740qka.14.2020.05.19.17.00.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2020 17:00:55 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jbCAJ-0001cg-A4; Tue, 19 May 2020 21:00:55 -0300 Date: Tue, 19 May 2020 21:00:55 -0300 From: Jason Gunthorpe To: Dennis Dalessandro Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, Mike Marciniszyn , stable@vger.kernel.org, Kaike Wan Subject: Re: [PATCH for-rc or next 3/3] IB/qib: Call kobject_put() when kobject_init_and_add() fails Message-ID: <20200520000055.GA6205@ziepe.ca> References: <20200512030622.189865.65024.stgit@awfm-01.aw.intel.com> <20200512031328.189865.48627.stgit@awfm-01.aw.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200512031328.189865.48627.stgit@awfm-01.aw.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, May 11, 2020 at 11:13:28PM -0400, Dennis Dalessandro wrote: > From: Kaike Wan > > When kobject_init_and_add() returns an error in the function > qib_create_port_files(), the function kobject_put() is not called for > the corresponding kobject, which potentially leads to memory leak. > > This patch fixes the issue by calling kobject_put() even if > kobject_init_and_add() fails. In addition, the ppd->diagc_kobj is > released along with other kobjects when the sysfs is unregistered. > > Fixes: f931551bafe1 ("IB/qib: Add new qib driver for QLogic PCIe InfiniBand adapters") > Cc: > Suggested-by: Lin Yi > Reviewed-by: Mike Marciniszyn > Signed-off-by: Kaike Wan > Signed-off-by: Dennis Dalessandro > Reviewed-by: Leon Romanovsky > --- > drivers/infiniband/hw/qib/qib_sysfs.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Applied to for-rc Are you respinning the other two patches? Thanks, Jason