From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9201CC433E1 for ; Wed, 20 May 2020 12:57:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C17F2070A for ; Wed, 20 May 2020 12:57:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="hgVTZa0T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbgETM5L (ORCPT ); Wed, 20 May 2020 08:57:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726818AbgETM5K (ORCPT ); Wed, 20 May 2020 08:57:10 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FFB5C061A0F for ; Wed, 20 May 2020 05:57:09 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id x13so1249182qvr.2 for ; Wed, 20 May 2020 05:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NvhkpsgiFlCMhi8iFQGtwEX6GRKqAUUpVVhE3XynkAU=; b=hgVTZa0Toidamqjtj9i7BaX6Pf3W1DFUXWv32c2VKUZ9gJpMuTRugh7fqsHisHkIso qu0Ch6/1Yf6EQNG8DtYpVglovTa1Sq/fyp73SEeTVFDKMrVfHigNnHytIuEzlRXk2NHd Mdw+ByGUm+JErwXij8Zpgd/vAJ4LMOD+jPUqB/pwVAyI29A+cn1v5l8s3pX6J9aHGHMm NqymeSJxeITxYKwyZtFQ8vRNOeZcI8hzdr5kXehHqKk9JWCsRHWJsfZjLmkZpeXqCl9s ecfzFeijKpgzLe33W3+cxqEAKutdVFLTBiiDTbOeMIy56zR/5Nh102J8Pjyjf67Ea7S+ 4t2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NvhkpsgiFlCMhi8iFQGtwEX6GRKqAUUpVVhE3XynkAU=; b=FOlhPywRhCIeVi+zGl4QC3TJpUvb6wietGvhjO51ZzQey9dIN1qhdy7WH5nDZGJ4LJ Xjh32QZ0HiP6eoKVwIr3j+6qi5x/oW89+ov2erJIVnV3U4oEr/NJqYVmtjAWgviQdgRO 9AHrAZnARE98XLCdLJ6FYtwqUEcuaqpGF9XklWbYuduCqpb1PW9aC8XelgmOMIik+SiY 3YS5i9YmGnJsMkrTZRS0uXYOxYehMq4HHTfsXbUVUUo9kj3AKlcw6UGBxUwYH5wnMkEw e+BNC8pxFyqqKhYp/MPQnKttMJzvuzpMpYCPNYDZBPdcmXR22GmFm6HrdzhD7VJOaQB/ 9VEg== X-Gm-Message-State: AOAM5315EOcPwmO+3D9eqFexH/UY6GHV9f2yD4ul2aQ8Mggy6wonvRe3 hic9cHAZsfWeNR4irwH4m5Sgxg== X-Google-Smtp-Source: ABdhPJw4S49naazllgVfN/YmWsUbmOHw54ems5BHWM36PeKPYCjqcTLRbOCPjdQ6dEq+FpNgFGJacA== X-Received: by 2002:ad4:5684:: with SMTP id bc4mr4765167qvb.85.1589979428391; Wed, 20 May 2020 05:57:08 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id y21sm2156720qkb.95.2020.05.20.05.57.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 May 2020 05:57:08 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jbOHT-0006CV-JE; Wed, 20 May 2020 09:57:07 -0300 Date: Wed, 20 May 2020 09:57:07 -0300 From: Jason Gunthorpe To: Jeff Kirsher Cc: davem@davemloft.net, gregkh@linuxfoundation.org, Ranjani Sridharan , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, pierre-louis.bossart@linux.intel.com, Fred Oh Subject: Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client Message-ID: <20200520125707.GJ31189@ziepe.ca> References: <20200520070227.3392100-1-jeffrey.t.kirsher@intel.com> <20200520070227.3392100-11-jeffrey.t.kirsher@intel.com> <20200520125437.GH31189@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520125437.GH31189@ziepe.ca> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, May 20, 2020 at 09:54:37AM -0300, Jason Gunthorpe wrote: > > + if (!time) { > > + dev_err(sdev->dev, "error: probe of virtbus dev %s timed out\n", > > + name); > > + virtbus_unregister_device(vdev); > > Unregister does kfree? In general I've found that to be a bad idea, > many drivers need to free up resources after unregistering from their > subsystem. oops, never mind, this is the driver side it makes some sense - but I'm not sure you should call it during error unwind anyhow. See above about the wait being kind of bonkers.. Jason