linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Gal Pressman <galpress@amazon.com>
Cc: Doug Ledford <dledford@redhat.com>,
	linux-rdma@vger.kernel.org,
	Alexander Matushevsky <matua@amazon.com>,
	Firas JahJah <firasj@amazon.com>,
	Yossi Leybovich <sleybo@amazon.com>
Subject: Re: [PATCH for-next v2 1/2] RDMA/efa: Fix setting of wrong bit in get/set_feature commands
Date: Thu, 21 May 2020 11:11:03 -0300	[thread overview]
Message-ID: <20200521141103.GB17583@ziepe.ca> (raw)
In-Reply-To: <4a6835db-0cc9-e94b-c86f-a8fafef0cf46@amazon.com>

On Thu, May 21, 2020 at 05:06:28PM +0300, Gal Pressman wrote:
> On 21/05/2020 16:57, Jason Gunthorpe wrote:
> > On Wed, May 20, 2020 at 11:03:00AM +0300, Gal Pressman wrote:
> >> On 20/05/2020 3:04, Jason Gunthorpe wrote:
> >>> On Tue, May 12, 2020 at 06:22:03PM +0300, Gal Pressman wrote:
> >>>> When using a control buffer the ctrl_data bit should be set in order to
> >>>> indicate the control buffer address is valid, not ctrl_data_indirect
> >>>> which is used when the control buffer itself is indirect.
> >>>>
> >>>> Reviewed-by: Firas JahJah <firasj@amazon.com>
> >>>> Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
> >>>> Signed-off-by: Gal Pressman <galpress@amazon.com>
> >>>>  drivers/infiniband/hw/efa/efa_com_cmd.c | 4 ++--
> >>>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> No fixes line??
> >>
> >> The reason I didn't add a fixes line (and sent it to for-next) is that it turns
> >> out this is the first set feature command to use a control buffer so nothing was
> >> broken, but this is necessary for patch #2 to work.
> > 
> > It should probably still have a fixes line in case someone decided to
> > backport the 2nd patch. But applied without
> 
> Hmm, you're right.
> If it isn't too late:
> Fixes: e9c6c5373088 ("RDMA/efa: Add common command handlers")

Okay done

Jason

  reply	other threads:[~2020-05-21 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 15:22 [PATCH for-next v2 0/2] EFA host information Gal Pressman
2020-05-12 15:22 ` [PATCH for-next v2 1/2] RDMA/efa: Fix setting of wrong bit in get/set_feature commands Gal Pressman
2020-05-20  0:04   ` Jason Gunthorpe
2020-05-20  8:03     ` Gal Pressman
2020-05-21 13:57       ` Jason Gunthorpe
2020-05-21 14:06         ` Gal Pressman
2020-05-21 14:11           ` Jason Gunthorpe [this message]
2020-05-12 15:22 ` [PATCH for-next v2 2/2] RDMA/efa: Report host information to the device Gal Pressman
2020-05-20  0:07   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200521141103.GB17583@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dledford@redhat.com \
    --cc=firasj@amazon.com \
    --cc=galpress@amazon.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    --cc=sleybo@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).