Re: [RDMA RFC v6 00/16] Intel RDMA Driver Updates 2020-05-19

[Jason Gunthorpe <jgg@mellanox.com>]

On Wed, May 20, 2020 at 12:03:59AM -0700, Jeff Kirsher wrote:
> This patch set adds a unified Intel Ethernet Protocol Driver for RDMA that
> supports a new network device E810 (iWARP and RoCEv2 capable) and the
> existing X722 iWARP device. The driver architecture provides the extensibility
> for future generations of Intel HW supporting RDMA.
> 
> This driver replaces the legacy X722 driver i40iw and extends the ABI already
> defined for i40iw. It is backward compatible with legacy X722 rdma-core
> provider (libi40iw).
> 
> This series was built against the rdma for-next branch.  This series is
> dependant upon the v4 100GbE Intel Wired LAN Driver Updates 2020-05-19
> 12 patch series, which adds virtual_bus interface and ice/i40e LAN
> driver changes.
> 
> v5-->v6:
> *Convert irdma destroy QP to a synchronous API 
> *Drop HMC obj macros for use counts like IRDMA_INC_SD_REFCNT et al.
> *cleanup unneccesary 'mem' variable in irdma_create_qp 
> *cleanup unused headers such as linux/moduleparam.h et. al 
> *set kernel_ver in irdma_ualloc_resp struct to current ABI ver. Placeholder to
>  support user-space compatbility checks in future 
> *GENMASK/FIELD_PREP scheme to set WQE descriptor fields considered for irdma
>  driver but decision to drop. The FIELD_PREP macro cannot be used on the device
>  bitfield mask array maintained for common WQE descriptors and initialized
>  based on HW generation. The macro expects compile time constants
> only.

The request was to use GENMASK for the #define constants. If you move
to a code environment then the spot the constant appears in the C code
should be FIELD_PREP'd into the something dynamic code can use.

Jason