From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: rdma-for-next lockdep complaint
Date: Fri, 22 May 2020 22:11:02 -0300 [thread overview]
Message-ID: <20200523011102.GN17583@ziepe.ca> (raw)
In-Reply-To: <70057e07-abd3-0254-1566-8c489cfa1c5f@acm.org>
On Fri, May 22, 2020 at 02:29:15PM -0700, Bart Van Assche wrote:
> Hi,
>
> If I run test srp/015 from the blktests test suite then the lockdep complaint
> shown below is reported. Since I haven't seen this complaint in the past I
> think that this is a regression. This complaint was triggered by the code on
> the for-next branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git. Is this a known
> issue?
I haven't seen it before, and it doesn't look like anything changed
here lately.
I think your test must have got unlucky to hit one of the
rdma_destroy_id paths.
It looks like a false positive from lockdep as these are never the
same lock.
Perhaps it could be fixed by lifting the mutex_unlock to before
the rdma_destroy_id ? Would need some study
Jason
prev parent reply other threads:[~2020-05-23 1:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 21:29 rdma-for-next lockdep complaint Bart Van Assche
2020-05-23 1:11 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523011102.GN17583@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).