* [PATCH] RDMA: fix missing pci disable in pvrdma_pci_probe()
@ 2020-05-23 3:04 wu000273
2020-05-25 17:24 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: wu000273 @ 2020-05-23 3:04 UTC (permalink / raw)
To: aditr; +Cc: pv-drivers, dledford, jgg, linux-rdma, linux-kernel, kjlu, wu000273
From: Qiushi Wu <wu000273@umn.edu>
In function pvrdma_pci_probe(), pdev was not disabled in one error
path. Thus replace the jump target “err_free_device” by
"err_disable_pdev".
Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
index e580ae9cc55a..780fd2dfc07e 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
@@ -829,7 +829,7 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,
!(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
dev_err(&pdev->dev, "PCI BAR region not MMIO\n");
ret = -ENOMEM;
- goto err_free_device;
+ goto err_disable_pdev;
}
ret = pci_request_regions(pdev, DRV_NAME);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] RDMA: fix missing pci disable in pvrdma_pci_probe()
2020-05-23 3:04 [PATCH] RDMA: fix missing pci disable in pvrdma_pci_probe() wu000273
@ 2020-05-25 17:24 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-05-25 17:24 UTC (permalink / raw)
To: wu000273; +Cc: aditr, pv-drivers, dledford, linux-rdma, linux-kernel, kjlu
On Fri, May 22, 2020 at 10:04:57PM -0500, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> In function pvrdma_pci_probe(), pdev was not disabled in one error
> path. Thus replace the jump target “err_free_device” by
> "err_disable_pdev".
>
> Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-25 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-23 3:04 [PATCH] RDMA: fix missing pci disable in pvrdma_pci_probe() wu000273
2020-05-25 17:24 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).