From: Jason Gunthorpe <jgg@ziepe.ca>
To: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
davem@davemloft.net, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com,
pierre-louis.bossart@linux.intel.com,
Fred Oh <fred.oh@linux.intel.com>
Subject: Re: [net-next v4 11/12] ASoC: SOF: Create client driver for IPC test
Date: Wed, 27 May 2020 21:12:07 -0300 [thread overview]
Message-ID: <20200528001207.GR744@ziepe.ca> (raw)
In-Reply-To: <b51ee1d61dbfbb8914d29338918ba49bff1b4b75.camel@linux.intel.com>
On Wed, May 27, 2020 at 01:18:35PM -0700, Ranjani Sridharan wrote:
> On Wed, 2020-05-20 at 09:56 -0300, Jason Gunthorpe wrote:
> > On Wed, May 20, 2020 at 12:02:26AM -0700, Jeff Kirsher wrote:
> > > +static const struct virtbus_dev_id sof_ipc_virtbus_id_table[] = {
> > > + {"sof-ipc-test"},
> > > + {},
> > > +};
> > > +
> > > +static struct sof_client_drv sof_ipc_test_client_drv = {
> > > + .name = "sof-ipc-test-client-drv",
> > > + .type = SOF_CLIENT_IPC,
> > > + .virtbus_drv = {
> > > + .driver = {
> > > + .name = "sof-ipc-test-virtbus-drv",
> > > + },
> > > + .id_table = sof_ipc_virtbus_id_table,
> > > + .probe = sof_ipc_test_probe,
> > > + .remove = sof_ipc_test_remove,
> > > + .shutdown = sof_ipc_test_shutdown,
> > > + },
> > > +};
> > > +
> > > +module_sof_client_driver(sof_ipc_test_client_drv);
> > > +
> > > +MODULE_DESCRIPTION("SOF IPC Test Client Driver");
> > > +MODULE_LICENSE("GPL v2");
> > > +MODULE_IMPORT_NS(SND_SOC_SOF_CLIENT);
> > > +MODULE_ALIAS("virtbus:sof-ipc-test");
> >
> > Usually the MODULE_ALIAS happens automatically rhough the struct
> > virtbus_dev_id - is something missing in the enabling patches?
> Hi Jason,
>
> Without the MODULE_ALIAS, the driver never probes when the virtual bus
> device is registered. The MODULE_ALIAS is not different from the ones
> we typically have in the platform drivers. Could you please give me
> some pointers on what you think might be missing?
Look at how the stuff in include/linux/mod_devicetable.h works and do
the same for virtbus
Looks like you push a MODALIAS= uevent when creating the device and
the generic machinery does the rest based on the matching table, once
mod_devicetable.h and related is updated. But it has been a long time
since I looked at this..
Jason
next prev parent reply other threads:[~2020-05-28 0:12 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:02 [net-next v4 00/12][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-19 Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 01/12] Implementation of Virtual Bus Jeff Kirsher
2020-05-21 14:57 ` Parav Pandit
2020-05-21 17:43 ` gregkh
2020-05-21 20:10 ` Jason Gunthorpe
2020-05-20 7:02 ` [net-next v4 02/12] ice: Create and register virtual bus for RDMA Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 03/12] ice: Complete RDMA peer registration Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 04/12] ice: Support resource allocation requests Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 05/12] ice: Enable event notifications Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 06/12] ice: Allow reset operations Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 07/12] ice: Pass through communications to VF Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 08/12] i40e: Move client header location Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 09/12] i40e: Register a virtbus device to provide RDMA Jeff Kirsher
2020-05-20 7:02 ` [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client Jeff Kirsher
2020-05-20 7:20 ` Greg KH
2020-05-20 12:54 ` Jason Gunthorpe
2020-05-20 12:57 ` Jason Gunthorpe
2020-05-21 21:11 ` Ranjani Sridharan
2020-05-21 23:34 ` Jason Gunthorpe
2020-05-22 14:29 ` Pierre-Louis Bossart
2020-05-22 14:55 ` Jason Gunthorpe
2020-05-22 15:33 ` Pierre-Louis Bossart
2020-05-22 17:10 ` Jason Gunthorpe
2020-05-22 18:35 ` Pierre-Louis Bossart
2020-05-22 18:40 ` Jason Gunthorpe
2020-05-22 18:48 ` Pierre-Louis Bossart
2020-05-22 19:44 ` Jason Gunthorpe
2020-05-22 21:05 ` Pierre-Louis Bossart
2020-06-29 20:59 ` Mark Brown
2020-05-23 6:23 ` Greg KH
2020-05-23 19:41 ` Pierre-Louis Bossart
2020-05-24 6:35 ` Greg KH
2020-05-26 13:15 ` Pierre-Louis Bossart
2020-05-26 13:37 ` Takashi Iwai
2020-05-27 7:17 ` Greg KH
2020-05-27 14:05 ` Pierre-Louis Bossart
2020-06-29 20:33 ` Mark Brown
2020-06-29 22:59 ` Jason Gunthorpe
2020-06-29 23:13 ` Kirsher, Jeffrey T
2020-06-30 10:31 ` Mark Brown
2020-06-30 11:32 ` Jason Gunthorpe
2020-06-30 14:16 ` Mark Brown
2020-06-30 17:24 ` Ranjani Sridharan
2020-06-30 17:27 ` Jason Gunthorpe
2020-07-01 9:50 ` Mark Brown
2020-07-01 23:32 ` Jason Gunthorpe
2020-07-02 11:15 ` Mark Brown
2020-07-02 12:11 ` Jason Gunthorpe
2020-07-02 12:20 ` Mark Brown
2020-07-01 6:59 ` Greg KH
2020-07-02 13:43 ` Ranjani Sridharan
2020-07-06 23:02 ` Dan Williams
2020-07-07 14:16 ` Greg KH
2020-05-25 16:55 ` Jason Gunthorpe
2020-06-29 20:21 ` Mark Brown
2020-06-29 17:36 ` Mark Brown
2020-05-20 7:02 ` [net-next v4 11/12] ASoC: SOF: Create client driver for IPC test Jeff Kirsher
2020-05-20 7:22 ` Greg KH
2020-05-20 12:56 ` Jason Gunthorpe
2020-05-27 20:18 ` Ranjani Sridharan
2020-05-28 0:12 ` Jason Gunthorpe [this message]
2020-05-28 1:40 ` Ranjani Sridharan
2020-05-28 10:45 ` Greg KH
2020-06-29 20:37 ` Mark Brown
2020-05-20 7:02 ` [net-next v4 12/12] ASoC: SOF: ops: Add new op for client registration Jeff Kirsher
2020-05-20 7:23 ` Greg KH
2020-05-20 7:17 ` [net-next v4 00/12][pull request] 100GbE Intel Wired LAN Driver Updates 2020-05-19 Greg KH
2020-05-20 7:25 ` Kirsher, Jeffrey T
2020-05-20 9:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528001207.GR744@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=davem@davemloft.net \
--cc=fred.oh@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).