From: Krishnamraju Eraparaju <krishna2@chelsio.com>
To: Sagi Grimberg <sagi@grimberg.me>, Max Gurtovoy <maxg@mellanox.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
linux-rdma@vger.kernel.org,
Potnuri Bharat Teja <bharat@chelsio.com>,
Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: iSERT completions hung due to unavailable iscsit tag
Date: Tue, 16 Jun 2020 15:19:05 +0530 [thread overview]
Message-ID: <20200616094904.GA21817@chelsio.com> (raw)
In-Reply-To: <20200604151341.GA20246@chelsio.com>
Hi Sagi/Max Gurtovoy,
Please suggest what else to look into for debugging this issue further.
Sagi, by any chance were you able to repoduce this on your VM(with SIW)
by reducing "tag_num" in iscsit?
I think, this issue will hit with any provider driver if we somehow let
the recv_done() handler reach the below "schedule()", while performing
IO.
------
static int iscsit_wait_for_tag(struct se_session *se_sess, int state,
int *cpup)
{
int tag = -1;
DEFINE_SBQ_WAIT(wait);
struct sbq_wait_state *ws;
struct sbitmap_queue *sbq;
if (state == TASK_RUNNING)
return tag;
sbq = &se_sess->sess_tag_pool;
ws = &sbq->ws[0];
for (;;) {
sbitmap_prepare_to_wait(sbq, ws, &wait, state);
if (signal_pending_state(state, current))
break;
tag = sbitmap_queue_get(sbq, cpup);
if (tag >= 0)
break;
schedule(); <======
}
sbitmap_finish_wait(sbq, ws, &wait);
return tag;
}
Thanks,
Krishna.
next prev parent reply other threads:[~2020-06-16 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 13:46 iSERT completions hung due to unavailable iscsit tag Krishnamraju Eraparaju
2020-06-03 20:27 ` Sagi Grimberg
2020-06-04 15:13 ` Krishnamraju Eraparaju
2020-06-16 9:49 ` Krishnamraju Eraparaju [this message]
2020-07-01 20:59 ` Krishnamraju Eraparaju
2020-06-05 5:07 ` Krishnamraju Eraparaju
2020-06-07 10:16 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616094904.GA21817@chelsio.com \
--to=krishna2@chelsio.com \
--cc=bharat@chelsio.com \
--cc=bvanassche@acm.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=nirranjan@chelsio.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).