From: Nathan Chancellor <natechancellor@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Sadanand Warrier <sadanand.warrier@intel.com>,
Kaike Wan <kaike.wan@intel.com>
Subject: Re: [PATCH v3 for-next 07/16] IB/ipoib: Increase ipoib Datagram mode MTU's upper limit
Date: Tue, 16 Jun 2020 11:42:31 -0700 [thread overview]
Message-ID: <20200616184231.GA3734396@ubuntu-n2-xlarge-x86> (raw)
In-Reply-To: <20200616062534.GB2141420@unreal>
On Tue, Jun 16, 2020 at 09:25:34AM +0300, Leon Romanovsky wrote:
> On Mon, Jun 15, 2020 at 05:56:50PM -0700, Nathan Chancellor wrote:
> > On Mon, Jun 01, 2020 at 10:57:22AM -0300, Jason Gunthorpe wrote:
> > > On Mon, Jun 01, 2020 at 09:48:47AM -0400, Dennis Dalessandro wrote:
> > >
> > > > They should probably all be in "enum ib_mtu". Jason any issues with us donig
> > > > that? I can't for certain recall the real reason they were kept separate in
> > > > the first place.
> > >
> > > It is probably OK
> > >
> > > Jason
> >
> > I don't mind taking a wack at this if you guys are too busy (I'm rather
> > tired of seeing the warning across all of my builds). However, I am
> > wondering how far should this be unwound? Should 'enum opa_mtu' be
> > collapsed into 'enum ib_mtu' and then all of the opa conversion
> > functions be eliminated in favor of the ib ones? It looks like
> > OPA_MTU_8192 and OPA_MTU_10240 are used in a few places within
> > drivers/infiniband/hw/hfi1, should all of those instances be converted
> > over to IB_MTU_* and the defines at the top of
> > drivers/infiniband/hw/hfi1/hfi.h be eliminated?
>
> We rather keep separation due to logic separation.
>
> While ib_* defines come from IBTA and interoperable across different
> devices and vendors, opa_* definitions are Intel proprietary ones used
> for the product that was canceled.
>
> Thanks
>
> >
> > Cheers,
> > Nathan
Fair enough, could someone take care of properly fixing the warning that
was introduced by this patch then? I can send a patch that just adds an
explicit cast but that looks like an eye sore to me. Otherwise, I am not
familiar enough with this code to know what is an appropriate fix or
not.
Cheers,
Nathan
next prev parent reply other threads:[~2020-06-16 18:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 16:05 [PATCH v3 for-next 00/16] New hfi1 feature: Accelerated IP Dennis Dalessandro
2020-05-11 16:05 ` [PATCH v3 for-next 01/16] IB/hfi1: Add accelerated IP capability bit Dennis Dalessandro
2020-05-11 16:05 ` [PATCH v3 for-next 02/16] IB/hfi1: Add functions to transmit datagram ipoib packets Dennis Dalessandro
2020-05-11 16:05 ` [PATCH v3 for-next 03/16] IB/hfi1: Add the transmit side of a datagram ipoib RDMA netdev Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 04/16] IB/hfi1: Remove module parameter for KDETH qpns Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 05/16] IB/{rdmavt, hfi1}: Implement creation of accelerated UD QPs Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 06/16] IB/hfi1: RSM rules for AIP Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 07/16] IB/ipoib: Increase ipoib Datagram mode MTU's upper limit Dennis Dalessandro
2020-05-27 4:03 ` Nathan Chancellor
2020-06-01 13:48 ` Dennis Dalessandro
2020-06-01 13:57 ` Jason Gunthorpe
2020-06-16 0:56 ` Nathan Chancellor
2020-06-16 6:25 ` Leon Romanovsky
2020-06-16 18:42 ` Nathan Chancellor [this message]
2020-06-16 19:17 ` Ira Weiny
2020-06-16 19:14 ` Dennis Dalessandro
2020-06-16 19:21 ` Ira Weiny
2020-06-16 19:27 ` Dennis Dalessandro
2020-06-17 4:35 ` Leon Romanovsky
2020-05-11 16:06 ` [PATCH v3 for-next 08/16] IB/hfi1: Rename num_vnic_contexts as num_netdev_contexts Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 09/16] IB/hfi1: Add functions to receive accelerated ipoib packets Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 10/16] IB/hfi1: Add interrupt handler functions for accelerated ipoib Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 11/16] IB/hfi1: Add rx functions for dummy netdev Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 12/16] IB/hfi1: Activate the " Dennis Dalessandro
2020-05-11 16:06 ` [PATCH v3 for-next 13/16] IB/{hfi1, ipoib, rdma}: Broadcast ping sent packets which exceeded mtu size Dennis Dalessandro
2020-05-11 16:07 ` [PATCH v3 for-next 14/16] IB/hfi1: Add packet histogram trace event Dennis Dalessandro
2020-05-11 16:07 ` [PATCH v3 for-next 15/16] IB/ipoib: Add capability to switch between datagram and connected mode Dennis Dalessandro
2020-05-11 16:07 ` [PATCH v3 for-next 16/16] IB/hfi1: Enable the transmit side of the datagram ipoib netdev Dennis Dalessandro
2020-05-21 19:55 ` [PATCH v3 for-next 00/16] New hfi1 feature: Accelerated IP Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616184231.GA3734396@ubuntu-n2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kaike.wan@intel.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=sadanand.warrier@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).