From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2108BC433E0 for ; Thu, 18 Jun 2020 11:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01ACC20663 for ; Thu, 18 Jun 2020 11:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592479525; bh=707sVmx0s5sjEkKRli2t2n9PWrs6S8hfMhcTE0f2riw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1imC8dhfbtgIBaMUqFfpbVKfU9qlP+agHsLQM+WDP1686cUXPy/CdcteVij1rtH27 l20S+yOCpb8H4JNhuNgPODCXtUMLfPLXaUgGcC5hf+LxLqoNE3jkCM1BboojNmN29W aSZDyTolSG20SOgmzh+xWY3eyrSI8gaHMegXMiyI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729482AbgFRLZX (ORCPT ); Thu, 18 Jun 2020 07:25:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:38594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728048AbgFRLZV (ORCPT ); Thu, 18 Jun 2020 07:25:21 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E49720663; Thu, 18 Jun 2020 11:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592479521; bh=707sVmx0s5sjEkKRli2t2n9PWrs6S8hfMhcTE0f2riw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j9WuNCuukhQnLapuBiEWZH/LYGaDO9x8Gzn58mfjCj0GgdQfnv2FIFf08j6osjcrf PJtZggZUdV/hxVsXfPE0ihHFwHsObnJE+BS6StXQwD0wc88IHMR5e8RSyN3TYlFEvb maGt8ZWKhcyol4oyFT60/ZQ5HLeAdHPCwiAOTfyI= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Maor Gottlieb , linux-rdma@vger.kernel.org, Mark Zhang Subject: [PATCH rdma-rc 2/2] RDMA/mlx5: Fix remote gid value in query QP Date: Thu, 18 Jun 2020 14:25:07 +0300 Message-Id: <20200618112507.3453496-3-leon@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200618112507.3453496-1-leon@kernel.org> References: <20200618112507.3453496-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Maor Gottlieb Remote gid is not copied to the right address. Fix it by using rdma_ah_set_dgid_raw to copy the remote gid value from the QP context on query QP. Fixes: 70bd7fb87625 ("RDMA/mlx5: Remove manually crafted QP context the query call") Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 0e42c50373d9..9b8012e941b8 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -4374,8 +4374,7 @@ static void to_rdma_ah_attr(struct mlx5_ib_dev *ibdev, MLX5_GET(ads, path, src_addr_index), MLX5_GET(ads, path, hop_limit), MLX5_GET(ads, path, tclass)); - memcpy(ah_attr, MLX5_ADDR_OF(ads, path, rgid_rip), - MLX5_FLD_SZ_BYTES(ads, rgid_rip)); + rdma_ah_set_dgid_raw(ah_attr, MLX5_ADDR_OF(ads, path, rgid_rip)); } } -- 2.26.2