From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24405C433DF for ; Sat, 20 Jun 2020 17:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE44023C19 for ; Sat, 20 Jun 2020 17:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernelim-com.20150623.gappssmtp.com header.i=@kernelim-com.20150623.gappssmtp.com header.b="rgXQ5z11" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbgFTRTO (ORCPT ); Sat, 20 Jun 2020 13:19:14 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45791 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725826AbgFTRTN (ORCPT ); Sat, 20 Jun 2020 13:19:13 -0400 Received: by mail-wr1-f67.google.com with SMTP id c3so12571690wru.12 for ; Sat, 20 Jun 2020 10:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelim-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G2k3vIU9c+LdwXojoMKQGH+WFL/QVe2uY1qAr2lifYk=; b=rgXQ5z11fb1M8RfnQ+KmpWjmoLRC9XaSKf0d85gK9y6pusXXFP4d0NiCBy1Xh0Cuof B8Sf9ivHaWlVhrW6jCHQZvGem+kYBwR7xz22TaQQMBgZSLZU99jYxz7aVnf9UplftUj5 ZvYcH2Eknr2eW9khksEb2QND+vifOnU71BdgbHYAK1XcRkA0ZFn5qzXNrYZNhhZzXwXS 1MtFOWB41jlMA2a7MWOFNcd1CSga9EFLM6DDL0oH/eZXi2/zqEGpJngoqbk9pj3l6K7x 5Xr7qfJl3XoYksDVVaU9l47zuJYwhufykXYekQnQ8L0Q5ceC3GfdAkO8/prSkg2UebOr DLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G2k3vIU9c+LdwXojoMKQGH+WFL/QVe2uY1qAr2lifYk=; b=Rdqn2zCu+5O8iOB2lNmLfzcM8RqwLgoN4Ol460prvi2h5HQFpoOFS59cwVR8wCeDC/ 4bXY4SojlQ1rj1lkO01YP/zS0pnmawKhMTHCuK+bw3M/iySAQAW5rtRvyc8ZbDZ6MmDA mj/xPlNoxRNmRNGwkyE0yoD9RIGAa6J8GuFvceslV2hekelGUCiyVwVH7y4mjRWwr1vo m/WrmhOXR47QdReous5SEtRA3G8wYio3hh5Qq+/xPXzK3pG41Q57AtLhRI1Fl16XBTdo 4tpZdUhIdu6rl1/4nKvixek10cikos002irm+aNH7leltGvqD9BX1W6j8RhhamM2oL/W E6YA== X-Gm-Message-State: AOAM532kj3CYb+3AI2VPEujm+o17bwLKIcHaXkK3DX0O+Dbgsp7FSuuC 2d3RsCCNj6+apnW0071CHAil0A== X-Google-Smtp-Source: ABdhPJyidO21nR/04RYkzohY6xrpoo3CcglCIkjIqiQkqKfJ4FIUKQhTuzygxJdkwbj9urYGpUTQYQ== X-Received: by 2002:adf:f14c:: with SMTP id y12mr9941989wro.30.1592673491513; Sat, 20 Jun 2020 10:18:11 -0700 (PDT) Received: from jupiter.home.aloni.org ([141.226.9.235]) by smtp.gmail.com with ESMTPSA id p16sm12286218wru.27.2020.06.20.10.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2020 10:18:11 -0700 (PDT) From: Dan Aloni To: Chuck Lever Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH] xprtrdma: Wake up re_connect_wait on disconnect Date: Sat, 20 Jun 2020 20:18:05 +0300 Message-Id: <20200620171805.1748399-1-dan@kernelim.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Given that rpcrdma_xprt_connect() happens from workqueue context, on cases where connections don't succeeds, something needs to wake it up. In my case, this has been observed when the CM callback received `RDMA_CM_EVENT_REJECTED`, and `rpcrdma_xprt_connect()` slept forever. This continues the fix in commit 58bd6656f808 ('xprtrdma: Restore wake-up-all to rpcrdma_cm_event_handler()'). Signed-off-by: Dan Aloni CC: Chuck Lever --- Notes: Hi Chuck, Maybe I missd something, as it is not clear to me how otherwise (without this patch), re_connect_wait can be woken up in this situation. Please explain? net/sunrpc/xprtrdma/verbs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index 2ae348377806..8bd76a47a91f 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -289,6 +289,7 @@ rpcrdma_cm_event_handler(struct rdma_cm_id *id, struct rdma_cm_event *event) ep->re_connect_status = -ECONNABORTED; disconnected: xprt_force_disconnect(xprt); + wake_up_all(&ep->re_connect_wait); return rpcrdma_ep_destroy(ep); default: break; -- 2.25.4