From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B14AC433E0 for ; Sun, 21 Jun 2020 11:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20CAB2489D for ; Sun, 21 Jun 2020 11:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592737212; bh=/YoThEFbqMBqdZ/ikVibUm5/aQUvKkYD2KZVRY0byEw=; h=From:To:Cc:Subject:Date:List-ID:From; b=vybrN6jKX79J6P445cROnmrKoSJF96ZxSmsYMnljLhe93gUbWjUa7Iak0F5Hj7gGR RbnLIoPHucXtr6JoE7XFTbs4Q8KRRBZVV5rV47aj04NjDa8Hoiawuw8W+bH6noFBm0 jpgyM+FA0EaJXqj8E4o/HvwkDKlYoEcs/uAJB0RY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729848AbgFULAL (ORCPT ); Sun, 21 Jun 2020 07:00:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:52670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729732AbgFULAG (ORCPT ); Sun, 21 Jun 2020 07:00:06 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DD192489D; Sun, 21 Jun 2020 11:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592737206; bh=/YoThEFbqMBqdZ/ikVibUm5/aQUvKkYD2KZVRY0byEw=; h=From:To:Cc:Subject:Date:From; b=X+gbXxxfSJoeMi3amn/D6i8vBDTaaVj+5Nbi2u9qFb80sG47FeuMGwb0KId02Oe0A YsIssYFNwsmZeHUBROtOD9S7OPfBv/LqLgxbbp8ZEUYbbr4vKq3Yh5kVDFqNJzqJpK QoPmf3AxaY/ZJWUe/qYKS92yKOJ7E5awfQd4HCfc= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Mark Zhang , linux-rdma@vger.kernel.org, Majd Dibbiny , Maor Gottlieb Subject: [PATCH rdma-rc] RDMA/counter: Query a counter before release Date: Sun, 21 Jun 2020 14:00:00 +0300 Message-Id: <20200621110000.56059-1-leon@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Mark Zhang Query a dynamically-allocated counter before release it, to update it's hwcounters and log all of them into history data. Otherwise all values of these hwcounters will be lost. Fixes: f34a55e497e8 ("RDMA/core: Get sum value of all counters when perform a sysfs stat read") Signed-off-by: Mark Zhang Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/counters.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/counters.c b/drivers/infiniband/core/counters.c index 2257d7f7810f..738d1faf4bba 100644 --- a/drivers/infiniband/core/counters.c +++ b/drivers/infiniband/core/counters.c @@ -202,7 +202,7 @@ static int __rdma_counter_unbind_qp(struct ib_qp *qp) return ret; } -static void counter_history_stat_update(const struct rdma_counter *counter) +static void counter_history_stat_update(struct rdma_counter *counter) { struct ib_device *dev = counter->device; struct rdma_port_counter *port_counter; @@ -212,6 +212,8 @@ static void counter_history_stat_update(const struct rdma_counter *counter) if (!port_counter->hstats) return; + rdma_counter_query_stats(counter); + for (i = 0; i < counter->stats->num_counters; i++) port_counter->hstats->value[i] += counter->stats->value[i]; } -- 2.26.2