archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <>
To: Dennis Dalessandro <>
	Mike Marciniszyn <>,
	Kaike Wan <>
Subject: Re: [PATCH for-rc 1/2] IB/hfi1: Restore kfree in dummy_netdev cleanup
Date: Wed, 24 Jun 2020 15:53:42 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Jun 23, 2020 at 04:32:24PM -0400, Dennis Dalessandro wrote:
> We need to do some rework on the dummy netdev. Calling the free_netdev() would
> normally make sense, and that will be addressed in an upcoming patch. For now
> just revert the behavior to what it was before keeping the unused variable
> removal part of the patch.
> The dd->dumm_netdev is mainly used for packet receiving through
> NAPI. Consequently, it is allocated with kcalloc_node instead of
> alloc_netdev_mqs for typical net devices.

Gross - make sure your rework allocates netdevs using alloc_netdev.


  reply	other threads:[~2020-06-24 18:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 20:32 [PATCH for-rc 0/2] Fixes for module unload Dennis Dalessandro
2020-06-23 20:32 ` [PATCH for-rc 1/2] IB/hfi1: Restore kfree in dummy_netdev cleanup Dennis Dalessandro
2020-06-24 18:53   ` Jason Gunthorpe [this message]
2020-06-25 18:11     ` Marciniszyn, Mike
2020-06-23 20:32 ` [PATCH for-rc 2/2] IB/hfi1: Fix module use count flaw due to leftover module put calls Dennis Dalessandro
2020-06-24 19:01 ` [PATCH for-rc 0/2] Fixes for module unload Jason Gunthorpe
2020-06-25 11:46   ` Dennis Dalessandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH for-rc 1/2] IB/hfi1: Restore kfree in dummy_netdev cleanup' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).