linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: rao.shoaib@oracle.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	ka-cheong.poon@oracle.com, david.edmondson@oracle.com
Subject: Re: [PATCH v1] rds: If one path needs re-connection, check all and re-connect
Date: Fri, 26 Jun 2020 16:31:00 -0700 (PDT)	[thread overview]
Message-ID: <20200626.163100.603726050168307590.davem@davemloft.net> (raw)
In-Reply-To: <20200626183438.20188-1-rao.shoaib@oracle.com>

From: rao.shoaib@oracle.com
Date: Fri, 26 Jun 2020 11:34:38 -0700

> +/* Check connectivity of all paths
> + */
> +void rds_check_all_paths(struct rds_connection *conn)
> +{
> +	int i = 0;
> +
> +	do {
> +		rds_conn_path_connect_if_down(&conn->c_path[i]);
> +	} while (++i < conn->c_npaths);
> +}

Please code this loop in a more canonial way:

	int i;

	for (i = 0; i < conn->c_npaths, i++)
		rds_conn_path_connect_if_down(&conn->c_path[i]);

Thank you.

  reply	other threads:[~2020-06-26 23:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 18:34 [PATCH v1] rds: If one path needs re-connection, check all and re-connect rao.shoaib
2020-06-26 23:31 ` David Miller [this message]
2020-06-29 17:55   ` Rao Shoaib
2020-06-29 19:23     ` David Miller
2020-07-01 19:23 rao.shoaib
2020-07-02  0:35 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626.163100.603726050168307590.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=david.edmondson@oracle.com \
    --cc=ka-cheong.poon@oracle.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rao.shoaib@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).