linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Hillf Danton <hdanton@sina.com>
Cc: kbuild-all@lists.01.org,
	syzbot <syzbot+a929647172775e335941@syzkaller.appspotmail.com>,
	chuck.lever@oracle.com, dledford@redhat.com, leon@kernel.org,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	parav@mellanox.com, Markus Elfring <Markus.Elfring@web.de>,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] RDMA/cma: Execute rdma_cm destruction from a handler properly
Date: Sat, 27 Jun 2020 10:38:18 +0800	[thread overview]
Message-ID: <202006271000.xehbxqGG%lkp@intel.com> (raw)
In-Reply-To: <20200627004519.GB25301@ziepe.ca>

[-- Attachment #1: Type: text/plain, Size: 3372 bytes --]

Hi Jason,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jason-Gunthorpe/RDMA-cma-Execute-rdma_cm-destruction-from-a-handler-properly/20200627-084914
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1590a2e1c681b0991bd42c992cabfd380e0338f2
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/infiniband/core/cma.c: In function 'cma_send_device_removal_put':
>> drivers/infiniband/core/cma.c:4787:3: error: implicit declaration of function 'spin_unlock_irqsave'; did you mean 'spin_lock_irqsave'? [-Werror=implicit-function-declaration]
    4787 |   spin_unlock_irqsave(&id_priv->lock, flags);
         |   ^~~~~~~~~~~~~~~~~~~
         |   spin_lock_irqsave
>> drivers/infiniband/core/cma.c:4789:3: error: implicit declaration of function 'cm_id_put'; did you mean 'cma_id_put'? [-Werror=implicit-function-declaration]
    4789 |   cm_id_put(id_priv);
         |   ^~~~~~~~~
         |   cma_id_put
   drivers/infiniband/core/cma.c: In function 'cma_process_remove':
   drivers/infiniband/core/cma.c:4813:6: warning: unused variable 'ret' [-Wunused-variable]
    4813 |  int ret;
         |      ^~~
   cc1: some warnings being treated as errors

vim +4787 drivers/infiniband/core/cma.c

  4775	
  4776	static void cma_send_device_removal_put(struct rdma_id_private *id_priv)
  4777	{
  4778		struct rdma_cm_event event = { .event = RDMA_CM_EVENT_DEVICE_REMOVAL };
  4779		enum rdma_cm_state state;
  4780		unsigned long flags;
  4781	
  4782		/* Record that we want to remove the device */
  4783		mutex_lock(&id_priv->handler_mutex);
  4784		spin_lock_irqsave(&id_priv->lock, flags);
  4785		state = id_priv->state;
  4786		if (state == RDMA_CM_DESTROYING || state == RDMA_CM_DEVICE_REMOVAL) {
> 4787			spin_unlock_irqsave(&id_priv->lock, flags);
  4788			mutex_unlock(&id_priv->handler_mutex);
> 4789			cm_id_put(id_priv);
  4790			return;
  4791		}
  4792		id_priv->state = RDMA_CM_DEVICE_REMOVAL;
  4793		spin_unlock_irqsave(&id_priv->lock, flags);
  4794	
  4795		if (cma_cm_event_handler(id_priv, &event)) {
  4796			mutex_unlock(&id_priv->handler_mutex);
  4797			cm_id_put(id_priv);
  4798			trace_cm_id_destroy(id_priv);
  4799			_destroy_id(id_priv, state);
  4800			return;
  4801		}
  4802		mutex_unlock(&id_priv->handler_mutex);
  4803	
  4804		/* The thread that assigns state does the cancel */
  4805		cma_cancel_operation(id_priv, state);
  4806	
  4807		cm_id_put(id_priv);
  4808	}
  4809	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67044 bytes --]

  reply	other threads:[~2020-06-27  2:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 17:02 KASAN: use-after-free Read in addr_handler (2) syzbot
     [not found] ` <20200614085321.8740-1-hdanton@sina.com>
2020-06-27  0:45   ` Jason Gunthorpe
2020-06-27  2:38     ` kernel test robot [this message]
     [not found]   ` <20200627130205.16900-1-hdanton@sina.com>
2020-06-27 22:25     ` Jason Gunthorpe
2020-06-29 14:42       ` Dmitry Vyukov
2020-06-29 17:27         ` Dmitry Vyukov
2020-06-29 19:22           ` Jason Gunthorpe
2020-06-29 19:41             ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006271000.xehbxqGG%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Markus.Elfring@web.de \
    --cc=chuck.lever@oracle.com \
    --cc=dledford@redhat.com \
    --cc=hdanton@sina.com \
    --cc=jgg@ziepe.ca \
    --cc=kbuild-all@lists.01.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=parav@mellanox.com \
    --cc=syzbot+a929647172775e335941@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --subject='Re: [PATCH] RDMA/cma: Execute rdma_cm destruction from a handler properly' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).