From: Alaa Hleihel <alaa@mellanox.com>
To: jgg@mellanox.com
Cc: linux-rdma@vger.kernel.org, Alaa Hleihel <alaa@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Edward Srouji <edwards@mellanox.com>,
Honggang Li <honli@redhat.com>
Subject: [PATCH rdma-core] redhat: Fix the condition for pyverbs enablement on Fedora 32 and up
Date: Sun, 28 Jun 2020 17:50:03 +0300 [thread overview]
Message-ID: <20200628145003.13705-1-alaa@mellanox.com> (raw)
The cited commit enabled pyverbs build by default for Fedora 32 and up.
However, it broke enalbing pyverbs build when passing '--with pyverbs' flag.
Fix the condition so that now the behavior for Fedora 32 and up will be:
* Default: pyverbs enabled.
* --with pyverbs: pyverbs enabled.
* --without pyverbs: pyverbs disabled.
Fixes: 07b304b75186 ("redhat: Build pyverbs for Fedora greater than release 31")
Signed-off-by: Alaa Hleihel <alaa@mellanox.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Tested-by: Edward Srouji <edwards@mellanox.com>
CC: Honggang Li <honli@redhat.com>
---
redhat/rdma-core.spec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/rdma-core.spec b/redhat/rdma-core.spec
index 7ff33b3ca8b8..76549e5cb61f 100644
--- a/redhat/rdma-core.spec
+++ b/redhat/rdma-core.spec
@@ -28,7 +28,7 @@ BuildRequires: valgrind-devel
BuildRequires: systemd
BuildRequires: systemd-devel
%if 0%{?fedora} >= 32
-%define with_pyverbs %{?_with_pyverbs: 0} %{?!_with_pyverbs: 1}
+%define with_pyverbs %{?_with_pyverbs: 1} %{?!_with_pyverbs: %{?!_without_pyverbs: 1} %{?_without_pyverbs: 0}}
%else
%define with_pyverbs %{?_with_pyverbs: 1} %{?!_with_pyverbs: 0}
%endif
--
2.26.2
next reply other threads:[~2020-06-28 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 14:50 Alaa Hleihel [this message]
2020-06-29 10:58 ` [PATCH rdma-core] redhat: Fix the condition for pyverbs enablement on Fedora 32 and up Honggang LI
2020-06-30 10:31 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200628145003.13705-1-alaa@mellanox.com \
--to=alaa@mellanox.com \
--cc=edwards@mellanox.com \
--cc=honli@redhat.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).