linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@mellanox.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] RDMA/ucma: Put a lock around every call to the rdma_cm layer
Date: Mon, 29 Jun 2020 11:30:12 -0300	[thread overview]
Message-ID: <20200629143012.GH23821@mellanox.com> (raw)
In-Reply-To: <20200627225734.GL7065@sol.localdomain>

On Sat, Jun 27, 2020 at 03:57:34PM -0700, Eric Biggers wrote:
 
> Hi Jason, here's my latest list (updated today) of bugs that are probably in
> drivers/infiniband/:

Thanks, lets see:
 
> Title:              general protection fault in rds_ib_add_one
> Last occurred:      1 day ago
> Reported:           124 days ago
> Branches:           Mainline and others
> Dashboard link:     https://syzkaller.appspot.com/bug?id=15f96d171c64999196ac7db3de107f24b9182a8e
> Original thread:    https://lore.kernel.org/lkml/000000000000b9b7d4059f4e4ac7@google.com/T/#u
> 
> This bug has a C reproducer.
> 
> The original thread for this bug received 5 replies; the last was 117 days ago.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+274094e62023782eeb17@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/000000000000b9b7d4059f4e4ac7@google.com

This is RDS, Hillif and Santos were handling it.. I pinged the thread

 
> Title:              WARNING in srp_remove_one
> Last occurred:      0 days ago
> Reported:           118 days ago
> Branches:           Mainline and others
> Dashboard link:     https://syzkaller.appspot.com/bug?id=16a5827f8f6f6ef0967e6492ffb2e2ca54c8c0fb
> Original thread:    https://lore.kernel.org/lkml/000000000000144d79059fc9415d@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> No one replied to the original thread for this bug.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+687bc62a84a6a2a3555a@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/000000000000144d79059fc9415d@google.com

This is *probably* the 'sysfs problem'

I have a good guess what this is, but I really need to see a
reproduction on it before trying to fix it. I can probably make the
odds of hitting this much higher with a patch, but syzkaller would
have to chew on that patch for a while to find a reproduction..

> Title:              WARNING in ib_uverbs_remove_one
> Last occurred:      0 days ago
> Reported:           99 days ago
> Branches:           Mainline and others
> Dashboard link:     https://syzkaller.appspot.com/bug?id=7d092a26c44ac45dc0a59a1a0474be064db8fa66
> Original thread:    https://lore.kernel.org/lkml/000000000000c3a75205a14cb8c9@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> No one replied to the original thread for this bug.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+d3f37b9458fe8281d078@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/000000000000c3a75205a14cb8c9@google.com

This is *probably* the 'sysfs problem'

> Title:              WARNING in ib_free_port_attrs
> Last occurred:      1 day ago
> Reported:           117 days ago
> Branches:           Mainline and others
> Dashboard link:     https://syzkaller.appspot.com/bug?id=4ec089798f282f2d2c3219151e420ed1ba10120d
> Original thread:    https://lore.kernel.org/lkml/000000000000460717059fd83734@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> The original thread for this bug received 1 reply, 116 days ago.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+e909641b84b5bc17ad8b@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/000000000000460717059fd83734@google.com

This is *probably* the 'sysfs problem', but not as clear

> Title:              WARNING in ib_umad_kill_port
> Last occurred:      1 day ago
> Reported:           82 days ago
> Branches:           Mainline and others
> Dashboard link:     https://syzkaller.appspot.com/bug?id=4ecc18c71d37b62b131aee8184a642ae5d2d21a6
> Original thread:    https://lore.kernel.org/lkml/00000000000075245205a2997f68@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> The original thread for this bug has received 8 replies; the last was 79 days
> ago.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+9627a92b1f9262d5d30c@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/00000000000075245205a2997f68@google.com

This is *probably* the 'sysfs problem'

> Title:              KASAN: use-after-free Write in addr_resolve
> Last occurred:      20 days ago
> Reported:           17 days ago
> Branches:           Mainline
> Dashboard link:     https://syzkaller.appspot.com/bug?id=e0a96faaf6799220954d5f5d8ec6fa0c386f85ac
> Original thread:    https://lore.kernel.org/lkml/000000000000eb293205a7bdd19a@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> No one has replied to the original thread for this bug yet.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+08092148130652a6faae@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/000000000000eb293205a7bdd19a@google.com

I think I have a fix for this

> Title:              KASAN: use-after-free Read in addr_handler (2)
> Last occurred:      17 days ago
> Reported:           17 days ago
> Branches:           Mainline
> Dashboard link:     https://syzkaller.appspot.com/bug?id=cfd37bf8b5d2768b6b87e7b4c3a588a06ea6284a
> Original thread:    https://lore.kernel.org/lkml/000000000000107b4605a7bdce7d@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> The original thread for this bug has received 2 replies; the last was 20 hours
> ago.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+a929647172775e335941@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please reply to the original
> thread, which had activity only 20 hours ago.  For the git send-email command to
> use, or tips on how to reply if the thread isn't in your mailbox, see the "Reply
> instructions" at https://lore.kernel.org/r/000000000000107b4605a7bdce7d@google.com

Probably a dup of the above

> Title:              KASAN: use-after-free Read in ib_uverbs_remove_one
> Last occurred:      33 days ago
> Reported:           30 days ago
> Branches:           linux-next
> Dashboard link:     https://syzkaller.appspot.com/bug?id=f1a3b9d9350867a50d642b8e2cee217569b8adca
> Original thread:    https://lore.kernel.org/lkml/00000000000095442505a6b63551@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> The original thread for this bug has received 2 replies; the last was 28 days
> ago.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+478fd0d54412b8759e0d@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/00000000000095442505a6b63551@google.com

Couldn't figure it out.

> Title:              WARNING in ib_unregister_device_queued
> Last occurred:      51 days ago
> Reported:           62 days ago
> Branches:           net
> Dashboard link:     https://syzkaller.appspot.com/bug?id=979c332b27ca869bd26c337574ef068908c1da3c
> Original thread:    https://lore.kernel.org/lkml/000000000000aa012505a431c7d9@google.com/T/#u
> 
> Unfortunately, this bug does not have a reproducer.
> 
> The original thread for this bug has received 2 replies; the last was 60 days
> ago.
> 
> If you fix this bug, please add the following tag to the commit:
>     Reported-by: syzbot+4088ed905e4ae2b0e13b@syzkaller.appspotmail.com
> 
> If you send any email or patch for this bug, please consider replying to the
> original thread.  For the git send-email command to use, or tips on how to reply
> if the thread isn't in your mailbox, see the "Reply instructions" at
> https://lore.kernel.org/r/000000000000aa012505a431c7d9@google.com

Fix sent

Jason 

  reply	other threads:[~2020-06-29 19:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 21:04 [PATCH] RDMA/ucma: Put a lock around every call to the rdma_cm layer Jason Gunthorpe
2020-02-18 22:10 ` KASAN: use-after-free Read in rdma_listen (2) syzbot
2020-02-19  6:07 ` [PATCH] RDMA/ucma: Put a lock around every call to the rdma_cm layer Eric Biggers
2020-02-19 20:22   ` Jason Gunthorpe
2020-03-07 20:41     ` Eric Biggers
2020-03-09 19:30       ` Jason Gunthorpe
2020-06-27 22:57         ` Eric Biggers
2020-06-29 14:30           ` Jason Gunthorpe [this message]
2020-11-16 20:46           ` Jason Gunthorpe
2020-02-27 20:42 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629143012.GH23821@mellanox.com \
    --to=jgg@mellanox.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).