archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <>
To: Doug Ledford <>, Jason Gunthorpe <>
Cc: Leon Romanovsky <>,, Maor Gottlieb <>
Subject: [PATCH rdma-rc] RDMA/mlx5: Fix legacy IPoIB QP initialization
Date: Tue, 30 Jun 2020 15:21:47 +0300	[thread overview]
Message-ID: <> (raw)

From: Leon Romanovsky <>

Legacy IPoIB sets IB_QP_CREATE_NETIF_QP QP create flag and because
mlx5 doesn't use this flag, the process_create_flags() failed to
create IPoIB QPs.

Fixes: 2978975ce7f1 ("RDMA/mlx5: Process create QP flags in one place")
Signed-off-by: Leon Romanovsky <>
 drivers/infiniband/hw/mlx5/qp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index f939c9b769f0..b316c9cafbc5 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2668,6 +2668,10 @@ static int process_create_flags(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp,
 	if (qp_type == IB_QPT_RAW_PACKET && attr->rwq_ind_tbl)
 		return (create_flags) ? -EINVAL : 0;
+	process_create_flag(dev, &create_flags, IB_QP_CREATE_NETIF_QP,
+			    mlx5_get_flow_namespace(dev->mdev,
+			    qp);
 	process_create_flag(dev, &create_flags,
 			    MLX5_CAP_GEN(mdev, sho), qp);

             reply	other threads:[~2020-06-30 12:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 12:21 Leon Romanovsky [this message]
2020-07-02 14:26 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH rdma-rc] RDMA/mlx5: Fix legacy IPoIB QP initialization' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).