From: Leon Romanovsky <leon@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Tariq Toukan <tariqt@mellanox.com>,
Jakub Kicinski <kuba@kernel.org>,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next] mlx4: Mark PM functions as __maybe_unused
Date: Thu, 2 Jul 2020 12:36:01 +0300 [thread overview]
Message-ID: <20200702093601.GB4837@unreal> (raw)
In-Reply-To: <20200702091946.5144-1-weiyongjun1@huawei.com>
On Thu, Jul 02, 2020 at 05:19:46PM +0800, Wei Yongjun wrote:
> In certain configurations without power management support, the
> following warnings happen:
>
> drivers/net/ethernet/mellanox/mlx4/main.c:4388:12:
> warning: 'mlx4_resume' defined but not used [-Wunused-function]
> 4388 | static int mlx4_resume(struct device *dev_d)
> | ^~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx4/main.c:4373:12: warning:
> 'mlx4_suspend' defined but not used [-Wunused-function]
> 4373 | static int mlx4_suspend(struct device *dev_d)
> | ^~~~~~~~~~~~
>
> Mark these functions as __maybe_unused to make it clear to the
> compiler that this is going to happen based on the configuration,
> which is the standard for these types of functions.
>
> Fixes: 0e3e206a3e12 ("mlx4: use generic power management")
I can't find this SHA-1, where did you get it?
And why doesn't mlx5 need this change?
Fixes: 86a3e5d02c20 ("net/mlx4_core: Add PCI calls for suspend/resume")
Thanks
next prev parent reply other threads:[~2020-07-02 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 9:19 [PATCH net-next] mlx4: Mark PM functions as __maybe_unused Wei Yongjun
2020-07-02 9:36 ` Leon Romanovsky [this message]
2020-07-02 10:27 ` Wei Yongjun
2020-07-02 11:58 ` Leon Romanovsky
2020-07-02 13:44 ` Jason Gunthorpe
2020-07-02 21:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702093601.GB4837@unreal \
--to=leon@kernel.org \
--cc=hulkci@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
--cc=vaibhavgupta40@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).