From: Kamal Heib <kamalheib1@gmail.com>
To: linux-rdma@vger.kernel.org
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Zhu Yanjun <yanjunz@mellanox.com>,
Kamal Heib <kamalheib1@gmail.com>
Subject: [PATCH for-next v1 2/4] RDMA/rxe: Return void from rxe_init_port_param()
Date: Sun, 5 Jul 2020 13:43:11 +0300 [thread overview]
Message-ID: <20200705104313.283034-3-kamalheib1@gmail.com> (raw)
In-Reply-To: <20200705104313.283034-1-kamalheib1@gmail.com>
The return value from rxe_init_port_param() is always 0 - change it to
be void.
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/sw/rxe/rxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
index c7191b5e04a5..efcb72c92be6 100644
--- a/drivers/infiniband/sw/rxe/rxe.c
+++ b/drivers/infiniband/sw/rxe/rxe.c
@@ -111,7 +111,7 @@ static void rxe_init_device_param(struct rxe_dev *rxe)
}
/* initialize port attributes */
-static int rxe_init_port_param(struct rxe_port *port)
+static void rxe_init_port_param(struct rxe_port *port)
{
port->attr.state = IB_PORT_DOWN;
port->attr.max_mtu = IB_MTU_4096;
@@ -134,8 +134,6 @@ static int rxe_init_port_param(struct rxe_port *port)
port->attr.phys_state = RXE_PORT_PHYS_STATE;
port->mtu_cap = ib_mtu_enum_to_int(IB_MTU_256);
port->subnet_prefix = cpu_to_be64(RXE_PORT_SUBNET_PREFIX);
-
- return 0;
}
/* initialize port state, note IB convention that HCA ports are always
--
2.25.4
next prev parent reply other threads:[~2020-07-05 10:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 10:43 [PATCH for-next v1 0/4] RDMA/rxe: Cleanups and improvements Kamal Heib
2020-07-05 10:43 ` [PATCH for-next v1 1/4] RDMA/rxe: Drop pointless checks in rxe_init_ports Kamal Heib
2020-07-05 13:20 ` Leon Romanovsky
2020-07-05 10:43 ` Kamal Heib [this message]
2020-07-05 13:20 ` [PATCH for-next v1 2/4] RDMA/rxe: Return void from rxe_init_port_param() Leon Romanovsky
2020-07-05 10:43 ` [PATCH for-next v1 3/4] RDMA/rxe: Return void from rxe_mem_init_dma() Kamal Heib
2020-07-05 13:20 ` Leon Romanovsky
2020-07-05 10:43 ` [PATCH for-next v1 4/4] RDMA/rxe: Remove rxe_link_layer() Kamal Heib
2020-07-05 12:59 ` Zhu Yanjun
2020-07-05 13:21 ` Leon Romanovsky
2020-07-14 8:14 ` [PATCH for-next v1 0/4] RDMA/rxe: Cleanups and improvements Kamal Heib
2020-07-14 19:56 ` Jason Gunthorpe
2020-07-15 9:48 ` Kamal Heib
2020-07-16 17:01 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705104313.283034-3-kamalheib1@gmail.com \
--to=kamalheib1@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjunz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).