linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Maor Gottlieb <maorg@mellanox.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@mellanox.com>,
	linux-netdev <netdev@vger.kernel.org>,
	RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH iproute2-next v1 1/4] rdma: update uapi headers
Date: Sun, 5 Jul 2020 21:04:15 +0300	[thread overview]
Message-ID: <20200705180415.GB207186@unreal> (raw)
In-Reply-To: <e91ebfe0-87aa-0dc4-7c2c-48004cc761c7@gmail.com>

On Sun, Jul 05, 2020 at 09:02:42AM -0600, David Ahern wrote:
> On 6/24/20 4:40 AM, Leon Romanovsky wrote:
> > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h
> > index ae5a77a1..fe127b88 100644
> > --- a/rdma/include/uapi/rdma/rdma_netlink.h
> > +++ b/rdma/include/uapi/rdma/rdma_netlink.h
> > @@ -287,6 +287,12 @@ enum rdma_nldev_command {
> >
> >  	RDMA_NLDEV_CMD_STAT_DEL,
> >
> > +	RDMA_NLDEV_CMD_RES_QP_GET_RAW, /* can dump */
> > +
> > +	RDMA_NLDEV_CMD_RES_CQ_GET_RAW, /* can dump */
> > +
> > +	RDMA_NLDEV_CMD_RES_MR_GET_RAW, /* can dump */
> > +
> >  	RDMA_NLDEV_NUM_OPS
> >  };
>
> you are inserting new commands in the middle which breaks existing users
> of this API.

RDMA_NLDEV_NUM_OPS is not a command, but enum item to help calculate array
size, exactly like devlink_command in include/uapi/linux/devlink.h.

Thanks

>

  reply	other threads:[~2020-07-05 18:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24 10:40 [PATCH iproute2-next v1 0/4] RAW format dumps through RDMAtool Leon Romanovsky
2020-06-24 10:40 ` [PATCH iproute2-next v1 1/4] rdma: update uapi headers Leon Romanovsky
2020-06-25  8:15   ` Leon Romanovsky
2020-06-26  5:00     ` David Ahern
2020-07-05 15:02   ` David Ahern
2020-07-05 18:04     ` Leon Romanovsky [this message]
2020-07-05 18:07       ` David Ahern
2020-07-06  5:33         ` Leon Romanovsky
2020-06-24 10:40 ` [PATCH iproute2-next v1 2/4] rdma: Add support to get QP in raw format Leon Romanovsky
2020-06-24 10:40 ` [PATCH iproute2-next v1 3/4] rdma: Add support to get CQ " Leon Romanovsky
2020-06-24 10:40 ` [PATCH iproute2-next v1 4/4] rdma: Add support to get MR " Leon Romanovsky
2020-07-05 18:14 ` [PATCH iproute2-next v1 0/4] RAW format dumps through RDMAtool David Ahern
2020-07-06  5:34   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705180415.GB207186@unreal \
    --to=leon@kernel.org \
    --cc=dledford@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=jgg@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maorg@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).