From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Zhu Yanjun <yanjunz@mellanox.com>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next] RDMA/rxe: Skip dgid check in loopback mode
Date: Tue, 7 Jul 2020 13:31:28 -0300 [thread overview]
Message-ID: <20200707163128.GA1381043@nvidia.com> (raw)
In-Reply-To: <20200630123605.446959-1-leon@kernel.org>
On Tue, Jun 30, 2020 at 03:36:05PM +0300, Leon Romanovsky wrote:
> From: Zhu Yanjun <yanjunz@mellanox.com>
>
> In the loopback tests, the following call trace occurs.
>
> Call Trace:
> __rxe_do_task+0x1a/0x30 [rdma_rxe]
> rxe_qp_destroy+0x61/0xa0 [rdma_rxe]
> rxe_destroy_qp+0x20/0x60 [rdma_rxe]
> ib_destroy_qp_user+0xcc/0x220 [ib_core]
> uverbs_free_qp+0x3c/0xc0 [ib_uverbs]
> destroy_hw_idr_uobject+0x24/0x70 [ib_uverbs]
> uverbs_destroy_uobject+0x43/0x1b0 [ib_uverbs]
> uobj_destroy+0x41/0x70 [ib_uverbs]
> __uobj_get_destroy+0x39/0x70 [ib_uverbs]
> ib_uverbs_destroy_qp+0x88/0xc0 [ib_uverbs]
> ib_uverbs_handler_UVERBS_METHOD_INVOKE_WRITE+0xb9/0xf0 [ib_uverbs]
> ib_uverbs_cmd_verbs+0xb16/0xc30 [ib_uverbs]
>
> The root cause is that the actual RDMA connection is not created in the
> loopback tests and the rxe_match_dgid will fail randomly.
>
> To fix this call trace which appear in the loopback tests, skip check
> of the dgid.
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Zhu Yanjun <yanjunz@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/sw/rxe/rxe_recv.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-07-07 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 12:36 [PATCH rdma-next] RDMA/rxe: Skip dgid check in loopback mode Leon Romanovsky
2020-07-07 16:31 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707163128.GA1381043@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjunz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).