From: Bharata B Rao <bharata@linux.ibm.com>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org,
nouveau@lists.freedesktop.org, kvm-ppc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Jerome Glisse <jglisse@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Christoph Hellwig <hch@lst.de>,
Jason Gunthorpe <jgg@mellanox.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH v3 2/5] mm/migrate: add a flags parameter to migrate_vma
Date: Wed, 22 Jul 2020 17:21:11 +0530 [thread overview]
Message-ID: <20200722115111.GR7902@in.ibm.com> (raw)
In-Reply-To: <20200721213119.32344-3-rcampbell@nvidia.com>
On Tue, Jul 21, 2020 at 02:31:16PM -0700, Ralph Campbell wrote:
> The src_owner field in struct migrate_vma is being used for two purposes,
> it acts as a selection filter for which types of pages are to be migrated
> and it identifies device private pages owned by the caller. Split this
> into separate parameters so the src_owner field can be used just to
> identify device private pages owned by the caller of migrate_vma_setup().
> Rename the src_owner field to pgmap_owner to reflect it is now used only
> to identify which device private pages to migrate.
>
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> ---
> arch/powerpc/kvm/book3s_hv_uvmem.c | 4 +++-
> drivers/gpu/drm/nouveau/nouveau_dmem.c | 4 +++-
> include/linux/migrate.h | 13 +++++++++----
> lib/test_hmm.c | 6 ++++--
> mm/migrate.c | 6 ++++--
> 5 files changed, 23 insertions(+), 10 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv_uvmem.c b/arch/powerpc/kvm/book3s_hv_uvmem.c
> index 09d8119024db..6850bd04bcb9 100644
> --- a/arch/powerpc/kvm/book3s_hv_uvmem.c
> +++ b/arch/powerpc/kvm/book3s_hv_uvmem.c
> @@ -400,6 +400,7 @@ kvmppc_svm_page_in(struct vm_area_struct *vma, unsigned long start,
> mig.end = end;
> mig.src = &src_pfn;
> mig.dst = &dst_pfn;
> + mig.flags = MIGRATE_VMA_SELECT_SYSTEM;
>
> /*
> * We come here with mmap_lock write lock held just for
> @@ -577,7 +578,8 @@ kvmppc_svm_page_out(struct vm_area_struct *vma, unsigned long start,
> mig.end = end;
> mig.src = &src_pfn;
> mig.dst = &dst_pfn;
> - mig.src_owner = &kvmppc_uvmem_pgmap;
> + mig.pgmap_owner = &kvmppc_uvmem_pgmap;
> + mig.flags = MIGRATE_VMA_SELECT_DEVICE_PRIVATE;
>
> mutex_lock(&kvm->arch.uvmem_lock);
For the kvmppc changes above,
Reviewed-by: Bharata B Rao <bharata@linux.ibm.com>
next prev parent reply other threads:[~2020-07-22 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 21:31 [PATCH v3 0/5] mm/migrate: avoid device private invalidations Ralph Campbell
2020-07-21 21:31 ` [PATCH v3 1/5] nouveau: fix storing invalid ptes Ralph Campbell
2020-07-21 21:31 ` [PATCH v3 2/5] mm/migrate: add a flags parameter to migrate_vma Ralph Campbell
2020-07-22 11:51 ` Bharata B Rao [this message]
2020-07-21 21:31 ` [PATCH v3 3/5] mm/notifier: add migration invalidation type Ralph Campbell
2020-07-21 21:31 ` [PATCH v3 4/5] nouveau/svm: use the new migration invalidation Ralph Campbell
2020-07-21 21:31 ` [PATCH v3 5/5] mm/hmm/test: " Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722115111.GR7902@in.ibm.com \
--to=bharata@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bskeggs@redhat.com \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).