Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Dennis Dalessandro <dennis.dalessandro@intel.com>,
	Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2][next] IB/hfi1: Use fallthrough pseudo-keyword
Date: Fri, 24 Jul 2020 17:01:43 -0300
Message-ID: <20200724200143.GA3670533@nvidia.com> (raw)
In-Reply-To: <20200721133455.GA14363@embeddedor>

On Tue, Jul 21, 2020 at 08:34:55AM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
> 
> [1] https://www.kernel.org/doc/html/v5.7-rc7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> Changes in v2:
>  - Address fall-through markings in drivers/infiniband/hw/hfi1/chip.c
>    in a separate patch[2].
> 
>    [2] https://lore.kernel.org/lkml/20200709235250.GA26678@embeddedor/
> 
>  drivers/infiniband/hw/hfi1/firmware.c | 16 ----------------
>  drivers/infiniband/hw/hfi1/mad.c      |  9 ++++-----
>  drivers/infiniband/hw/hfi1/pio.c      |  2 +-
>  drivers/infiniband/hw/hfi1/pio_copy.c | 12 ++++++------
>  drivers/infiniband/hw/hfi1/platform.c | 10 +++++-----
>  drivers/infiniband/hw/hfi1/qp.c       |  2 +-
>  drivers/infiniband/hw/hfi1/qsfp.c     |  4 ++--
>  drivers/infiniband/hw/hfi1/rc.c       | 25 ++++++++++++-------------
>  drivers/infiniband/hw/hfi1/sdma.c     |  9 ++++-----
>  drivers/infiniband/hw/hfi1/tid_rdma.c |  4 ++--
>  drivers/infiniband/hw/hfi1/uc.c       |  8 ++++----
>  11 files changed, 41 insertions(+), 60 deletions(-)

Applied to for-next, thanks

Jason

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 13:34 Gustavo A. R. Silva
2020-07-24 20:01 ` Jason Gunthorpe [this message]
2020-07-24 20:13   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724200143.GA3670533@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=gustavoars@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git