From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Doug Ledford <dledford@redhat.com>
Cc: <linux-rdma@vger.kernel.org>, Gal Pressman <galpress@amazon.com>
Subject: [PATCH for-next] RDMA/core: Add a debug print when a driver is marked as non-kverbs provider
Date: Tue, 18 Aug 2020 11:38:31 +0300 [thread overview]
Message-ID: <20200818083831.92212-1-galpress@amazon.com> (raw)
Add a debug print which is emitted when a certain driver is marked as
non-kverbs provider. This allows for easier understanding of why kverbs
functionality isn't working in such cases.
In addition, print the name of the first mandatory verb that is missing.
This brings back use for the unused name field.
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
drivers/infiniband/core/device.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index d293b826acbc..dc5896040df9 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -293,6 +293,10 @@ static void ib_device_check_mandatory(struct ib_device *device)
for (i = 0; i < ARRAY_SIZE(mandatory_table); ++i) {
if (!*(void **) ((void *) &device->ops +
mandatory_table[i].offset)) {
+ ibdev_dbg(
+ device,
+ "Marking as non-kverbs provider due to missing mandatory verb %s",
+ mandatory_table[i].name);
device->kverbs_provider = false;
break;
}
--
2.28.0
next reply other threads:[~2020-08-18 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 8:38 Gal Pressman [this message]
2020-08-31 16:28 ` [PATCH for-next] RDMA/core: Add a debug print when a driver is marked as non-kverbs provider Jason Gunthorpe
2020-09-01 6:46 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818083831.92212-1-galpress@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).