linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kamal Heib <kamalheib1@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
	Leon Romanovsky <leon@kernel.org>,
	Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH v2 for-rc] RDMA/rxe: Fix panic when calling kmem_cache_create()
Date: Wed, 19 Aug 2020 00:15:45 +0300	[thread overview]
Message-ID: <20200818211545.GA936143@kheib-workstation> (raw)
In-Reply-To: <20200818163157.GY24045@ziepe.ca>

On Tue, Aug 18, 2020 at 01:31:57PM -0300, Jason Gunthorpe wrote:
> On Tue, Aug 18, 2020 at 05:25:04PM +0300, Kamal Heib wrote:
> > To avoid the following kernel panic when calling kmem_cache_create()
> > with a NULL pointer from pool_cache(), move the rxe_cache_init() to the
> > context of device initialization.
> 
> I think you've hit on a bigger bug than just this oops.
> 
> rxe_net_add() should never be called before rxe_module_init(), that
> surely subtly breaks all kinds of things.
> 
> Maybe it is time to remove these module parameters?
>
Yes, I agree, this can be done in for-next.

But at least can we take this patch to for-rc (stable) to fix this issue
in stable releases?

Thanks,
Kamal

> Jason

  reply	other threads:[~2020-08-18 21:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 14:25 [PATCH v2 for-rc] RDMA/rxe: Fix panic when calling kmem_cache_create() Kamal Heib
2020-08-18 16:31 ` Jason Gunthorpe
2020-08-18 21:15   ` Kamal Heib [this message]
2020-08-20 11:37     ` Jason Gunthorpe
2020-08-23 19:45       ` Kamal Heib
2020-08-24  6:23         ` Leon Romanovsky
2020-08-24 13:47         ` Jason Gunthorpe
2020-08-24 15:34           ` Kamal Heib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818211545.GA936143@kheib-workstation \
    --to=kamalheib1@gmail.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).