From: Jason Gunthorpe <jgg@ziepe.ca>
To: Gal Pressman <galpress@amazon.com>
Cc: Kamal Heib <kamalheib1@gmail.com>,
linux-rdma@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Christian Benvenuti <benve@cisco.com>
Subject: Re: [PATCH for-next] RDMA/usnic: Remove the query_pkey callback
Date: Thu, 27 Aug 2020 09:01:39 -0300 [thread overview]
Message-ID: <20200827120139.GL24045@ziepe.ca> (raw)
In-Reply-To: <4be87aa7-bc3c-d8f1-05e2-9276125cacc2@amazon.com>
On Thu, Aug 27, 2020 at 11:20:16AM +0300, Gal Pressman wrote:
> On 27/08/2020 10:53, Kamal Heib wrote:
> > On Thu, Aug 20, 2020 at 04:53:38PM +0300, Kamal Heib wrote:
> >> On Thu, Aug 20, 2020 at 04:11:23PM +0300, Gal Pressman wrote:
> >>> On 20/08/2020 15:53, Kamal Heib wrote:
> >>>> Now that the query_pkey() isn't mandatory by the RDMA core, this
> >>>> callback can be removed from the usnic provider.
> >>>
> >>> Not directly related to this patch, but pyverbs has a test which verifies that
> >>> max_pkeys > 0, maybe this check should be removed.
> >>
> >> Or changed to work only for node_type == e.IBV_NODE_CA?
> >>
> >> Thanks,
> >> Kamal
> >
> > BTW, do the efa care about pkey?
>
> Depends.. We only support the default pkey so it doesn't do much in terms of
> functionality, but we still need to support it as part of the QP state machine
> for modify QP.
Does the pkey appear on the wire, or is it just some cruft for API sake?
Jason
next prev parent reply other threads:[~2020-08-27 12:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 12:53 [PATCH for-next] RDMA/usnic: Remove the query_pkey callback Kamal Heib
2020-08-20 13:11 ` Gal Pressman
2020-08-20 13:53 ` Kamal Heib
2020-08-27 7:53 ` Kamal Heib
2020-08-27 8:20 ` Gal Pressman
2020-08-27 12:01 ` Jason Gunthorpe [this message]
2020-08-27 12:20 ` Håkon Bugge
2020-08-27 12:58 ` Gal Pressman
2020-08-27 13:01 ` Jason Gunthorpe
2020-08-27 13:10 ` Gal Pressman
2020-08-27 13:55 ` Jason Gunthorpe
2020-08-27 14:08 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827120139.GL24045@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=benve@cisco.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).