From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Yishai Hadas <yishaih@mellanox.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next 2/4] IB/core: Enable ODP sync without faulting
Date: Wed, 16 Sep 2020 21:30:09 +0300 [thread overview]
Message-ID: <20200916183009.GM486552@unreal> (raw)
In-Reply-To: <20200916182523.GA7233@infradead.org>
On Wed, Sep 16, 2020 at 07:25:23PM +0100, Christoph Hellwig wrote:
> On Wed, Sep 16, 2020 at 09:19:11PM +0300, Leon Romanovsky wrote:
> > On Wed, Sep 16, 2020 at 05:47:06PM +0100, Christoph Hellwig wrote:
> > > > + if (fault) {
> > > > + /*
> > > > + * Since we asked for hmm_range_fault() to populate pages,
> > >
> > > Totally pointless line over 80 characters.
> >
> > checkpatch.pl was updated to allow 100 symbols.
>
> checkpatch.pl doesn't matter, it is in fact pretty silly. The coding
> style document says:
>
> "The preferred limit on the length of a single line is 80 columns.
>
> Statements longer than 80 columns should be broken into sensible chunks,
> unless exceeding 80 columns significantly increases readability and does
> not hide information."
>
> and that absolutely is not the case here, you could trivially move the
> last word into the next line and would not even increase the line count.
I'm not arguing, just explained why it was missed.
Thanks
next prev parent reply other threads:[~2020-09-16 18:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 11:39 [PATCH rdma-next 0/4] Improve ODP by using HMM API Leon Romanovsky
2020-09-14 11:39 ` [PATCH rdma-next 1/4] IB/core: Improve ODP to use hmm_range_fault() Leon Romanovsky
2020-09-16 16:45 ` Christoph Hellwig
2020-09-16 17:21 ` Jason Gunthorpe
2020-09-16 17:22 ` Christoph Hellwig
2020-09-17 10:01 ` Yishai Hadas
2020-09-17 9:54 ` Yishai Hadas
2020-09-14 11:39 ` [PATCH rdma-next 2/4] IB/core: Enable ODP sync without faulting Leon Romanovsky
2020-09-16 16:47 ` Christoph Hellwig
2020-09-16 18:19 ` Leon Romanovsky
2020-09-16 18:25 ` Christoph Hellwig
2020-09-16 18:30 ` Leon Romanovsky [this message]
2020-09-17 10:05 ` Yishai Hadas
2020-09-14 11:39 ` [PATCH rdma-next 3/4] RDMA/mlx5: Extend advice MR to support non faulting mode Leon Romanovsky
2020-09-14 11:39 ` [PATCH rdma-next 4/4] RDMA/mlx5: Sync device with CPU pages upon ODP MR registration Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916183009.GM486552@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=hch@infradead.org \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).