From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v2 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages
Date: Mon, 21 Sep 2020 12:18:13 +0300 [thread overview]
Message-ID: <20200921091813.GA1223944@unreal> (raw)
In-Reply-To: <20200921075725.GA19394@lst.de>
On Mon, Sep 21, 2020 at 09:57:25AM +0200, Christoph Hellwig wrote:
> I'm still not really sold on the explosion of specific sgl APIs, so
> I ended up implementing my original suggestion to reuse
> __sg_alloc_table_from_pages and just pass two additional parameters.
> I also ended up moving the memset out of __sg_alloc_table into its
> two callers, and I think the result looks much better, what do you
> think?
I think that the API call is really hard to grasp now with too many
arguments. Fun part will start when someone will decide to use this API
without some (expected for now) parameters.
I'm fond of more explicit interfaces.
Anyway, it is your area, we will retest it and resend.
Thanks
next prev parent reply other threads:[~2020-09-21 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 14:07 [PATCH rdma-next v2 0/2] scatterlist: add sg_alloc_table_append function Leon Romanovsky
2020-09-16 14:07 ` [PATCH rdma-next v2 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages Leon Romanovsky
2020-09-21 7:57 ` Christoph Hellwig
2020-09-21 9:18 ` Leon Romanovsky [this message]
2020-09-22 6:24 ` Christoph Hellwig
2020-09-22 6:32 ` Leon Romanovsky
2020-09-25 8:19 ` [lib/scatterlist] 71606c3597: last_state.is_incomplete_run kernel test robot
2020-09-16 14:07 ` [PATCH rdma-next v2 2/2] RDMA/umem: Move to allocate SG table from pages Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921091813.GA1223944@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).