linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: <zyjzyj2000@gmail.com>, <colin.king@canonical.com>,
	<linux-rdma@vger.kernel.org>, Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH for-next] RDMA/rxe - Respond to skb_clone failure in rxe_recv.c
Date: Fri, 16 Oct 2020 14:01:11 -0300	[thread overview]
Message-ID: <20201016170111.GA160906@nvidia.com> (raw)
In-Reply-To: <20201013184236.5231-1-rpearson@hpe.com>

On Tue, Oct 13, 2020 at 01:42:37PM -0500, Bob Pearson wrote:
> If skb_clone is unable to allocate memory for a new
> sk_buff this is not detected by the current code.
> 
> Check for a NULL return and continue. This is similar to
> other errors in this loop over QPs attached to the multicast address
> and consistent with the unreliable UD transport.
> 
> Fixes: e7ec96fc7932f ("RDMA/rxe: Fix skb lifetime in rxe_rcv_mcast_pkt()")
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_recv.c | 3 +++
>  1 file changed, 3 insertions(+)

Subject should be 'RDMA/rxe:' not '-'

Place () after function names for clarity

Flow text to the full 76 lines

I fixed it all up and applied to for-next

Thanks,
Jason

      parent reply	other threads:[~2020-10-16 17:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 18:42 [PATCH for-next] RDMA/rxe - Respond to skb_clone failure in rxe_recv.c Bob Pearson
2020-10-14  0:39 ` Zhu Yanjun
2020-10-16 17:01 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201016170111.GA160906@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=colin.king@canonical.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearson@hpe.com \
    --cc=rpearsonhpe@gmail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).