* [PATCH for-next] RDMA/uverbs: Fix false error in query gid IOCTL
@ 2020-10-26 8:26 Gal Pressman
2020-10-26 22:30 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Gal Pressman @ 2020-10-26 8:26 UTC (permalink / raw)
To: Jason Gunthorpe, Doug Ledford
Cc: linux-rdma, Leon Romanovsky, Avihai Horon, Gal Pressman, Leon Romanovsky
Some drivers (such as EFA) have a GID table, but aren't IB/RoCE devices.
Remove the unnecessary rdma_ib_or_roce() check.
Fixes: 9f85cbe50aa0 ("RDMA/uverbs: Expose the new GID query API to user space")
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
drivers/infiniband/core/uverbs_std_types_device.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/infiniband/core/uverbs_std_types_device.c b/drivers/infiniband/core/uverbs_std_types_device.c
index f367d523a46b..302f898c5833 100644
--- a/drivers/infiniband/core/uverbs_std_types_device.c
+++ b/drivers/infiniband/core/uverbs_std_types_device.c
@@ -401,9 +401,6 @@ static int UVERBS_HANDLER(UVERBS_METHOD_QUERY_GID_ENTRY)(
if (!rdma_is_port_valid(ib_dev, port_num))
return -EINVAL;
- if (!rdma_ib_or_roce(ib_dev, port_num))
- return -EOPNOTSUPP;
-
gid_attr = rdma_get_gid_attr(ib_dev, port_num, gid_index);
if (IS_ERR(gid_attr))
return PTR_ERR(gid_attr);
base-commit: c7a198c700763ac89abbb166378f546aeb9afb33
--
2.29.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-next] RDMA/uverbs: Fix false error in query gid IOCTL
2020-10-26 8:26 [PATCH for-next] RDMA/uverbs: Fix false error in query gid IOCTL Gal Pressman
@ 2020-10-26 22:30 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-10-26 22:30 UTC (permalink / raw)
To: Gal Pressman
Cc: Doug Ledford, linux-rdma, Leon Romanovsky, Avihai Horon, Leon Romanovsky
On Mon, Oct 26, 2020 at 10:26:21AM +0200, Gal Pressman wrote:
> Some drivers (such as EFA) have a GID table, but aren't IB/RoCE devices.
> Remove the unnecessary rdma_ib_or_roce() check.
>
> Fixes: 9f85cbe50aa0 ("RDMA/uverbs: Expose the new GID query API to user space")
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
> drivers/infiniband/core/uverbs_std_types_device.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-26 22:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 8:26 [PATCH for-next] RDMA/uverbs: Fix false error in query gid IOCTL Gal Pressman
2020-10-26 22:30 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).