From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Doug Ledford <dledford@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
Max Gurtovoy <mgurtovoy@nvidia.com>,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
Sagi Grimberg <sagi@grimberg.me>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH] RDMA: Add rdma_connect_locked()
Date: Tue, 27 Oct 2020 09:04:29 +0100 [thread overview]
Message-ID: <20201027080429.GA22725@lst.de> (raw)
In-Reply-To: <0-v1-75e124dbad74+b05-rdma_connect_locking_jgg@nvidia.com>
> +int rdma_connect_locked(struct rdma_cm_id *id, struct rdma_conn_param *conn_param)
This adds an overly long line.
> +int rdma_connect_locked(struct rdma_cm_id *id, struct rdma_conn_param *conn_param);
Same here.
Otherwise looks good except for the nvme merge error pointed out by
Chao Leng.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-10-27 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:25 [PATCH] RDMA: Add rdma_connect_locked() Jason Gunthorpe
2020-10-26 16:01 ` santosh.shilimkar
2020-10-27 2:01 ` Chao Leng
2020-10-27 12:00 ` Jason Gunthorpe
2020-10-27 7:33 ` Jinpu Wang
2020-10-27 8:04 ` Christoph Hellwig [this message]
2020-10-27 12:05 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027080429.GA22725@lst.de \
--to=hch@lst.de \
--cc=danil.kipnis@cloud.ionos.com \
--cc=dledford@redhat.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=jgg@nvidia.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kbusch@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sagi@grimberg.me \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).