From: Jason Gunthorpe <jgg@nvidia.com>
To: Weihang Li <liweihang@huawei.com>
Cc: <dledford@redhat.com>, <leon@kernel.org>,
<linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH v3 for-next] RDMA/hns: Support owner mode doorbell
Date: Wed, 28 Oct 2020 13:14:16 -0300 [thread overview]
Message-ID: <20201028161416.GA2438029@nvidia.com> (raw)
In-Reply-To: <1603195493-22741-1-git-send-email-liweihang@huawei.com>
On Tue, Oct 20, 2020 at 08:04:53PM +0800, Weihang Li wrote:
> From: Lang Cheng <chenglang@huawei.com>
>
> The doorbell needs to store PI information into QPC, so the RoCEE should
> wait for the results of storing, that is, it needs two bus operations to
> complete a doorbell. When ROCEE is in SDI mode, multiple doorbells may be
> interlocked because the RoCEE can only handle bus operations serially. So a
> flag to mark if HIP09 is working in SDI mode is added. When the SDI flag is
> set, the ROCEE will ignore the PI information of the doorbell, continue to
> fetch wqe and verify its validity by it's owner_bit.
>
> Signed-off-by: Lang Cheng <chenglang@huawei.com>
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
> Changes since v2:
> - Replace wmb() with dma_wmb().
> link: https://patchwork.kernel.org/project/linux-rdma/patch/1601199901-41677-1-git-send-email-liweihang@huawei.com/
>
> Changes since v1:
> - Fix comments from Leon about the unused enum.
> link: https://patchwork.kernel.org/patch/11799327/
>
> drivers/infiniband/hw/hns/hns_roce_device.h | 4 +++-
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 28 ++++++++++++++++++++++------
> drivers/infiniband/hw/hns/hns_roce_qp.c | 3 +++
> 3 files changed, 28 insertions(+), 7 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-10-28 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 12:04 [PATCH v3 for-next] RDMA/hns: Support owner mode doorbell Weihang Li
2020-10-28 16:14 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028161416.GA2438029@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).