From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34062C388F7 for ; Sat, 31 Oct 2020 17:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC494208A9 for ; Sat, 31 Oct 2020 17:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604164095; bh=Mw09u45BOHIABzfIiri3F7X5K7CUh0+5Rw6SY0INk3A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=tv9pMyAG99x/ewd4q2dVOSKSeL4V8JhG2/ODo9RgEofl9lTM27FXfthyn1UWTgUos FqdJIC48XZ6TMTCryNs0QbaYsZqTIDdgvS2BlGqHsDFmNCDHyW0HL6c/MalYGnJRo2 TJBNRUuKJuYt7N7OkjA/XnvxbOmRlrQm4P1DukTk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728190AbgJaRIL (ORCPT ); Sat, 31 Oct 2020 13:08:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:51944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgJaRIL (ORCPT ); Sat, 31 Oct 2020 13:08:11 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C3A6C206DC; Sat, 31 Oct 2020 17:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604164090; bh=Mw09u45BOHIABzfIiri3F7X5K7CUh0+5Rw6SY0INk3A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oSvD+IafsTffY12YssYphnyq1CGSiLQZYrnV0kxDYeAp9B54AcB0s1cbpAYcjabDw zy8wOV8hikf+zUnDgqfhmvMmNAhbqojdd34fXEJWiieRB32Huz2Cs5Aef/EhCK0Uk2 AXRUjnPnfa6UuiNSy5YOGzan8ugiyhO1oFrDzePk= Date: Sat, 31 Oct 2020 10:08:09 -0700 From: Jakub Kicinski To: Sebastian Andrzej Siewior Cc: netdev@vger.kernel.org, Aymen Sghaier , Daniel Drake , "David S. Miller" , Herbert Xu , Horia =?UTF-8?B?R2VhbnTEgw==?= , Jon Mason , Jouni Malinen , Kalle Valo , Leon Romanovsky , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, Li Yang , Madalin Bucur , Ping-Ke Shih , Rain River , Saeed Mahameed , Samuel Chessman , Ulrich Kunitz , Zhu Yanjun , Thomas Gleixner Subject: Re: [PATCH net-next 00/15] in_interrupt() cleanup, part 2 Message-ID: <20201031100809.300bf4ab@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201027225454.3492351-1-bigeasy@linutronix.de> References: <20201027225454.3492351-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, 27 Oct 2020 23:54:39 +0100 Sebastian Andrzej Siewior wrote: > Folks, > > in the discussion about preempt count consistency across kernel configurations: > > https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/ > > Linus clearly requested that code in drivers and libraries which changes > behaviour based on execution context should either be split up so that > e.g. task context invocations and BH invocations have different interfaces > or if that's not possible the context information has to be provided by the > caller which knows in which context it is executing. > > This includes conditional locking, allocation mode (GFP_*) decisions and > avoidance of code paths which might sleep. > > In the long run, usage of 'preemptible, in_*irq etc.' should be banned from > driver code completely. > > This is part two addressing remaining drivers except for orinoco-usb. Sebastian, thanks for there, I picked up only the Ethernet patches: 5ce7f3f46f6b net: neterion: s2io: Replace in_interrupt() for context detection dc5e8bfcd12e net: forcedeth: Replace context and lock check with a lockdep_assert() beca92820dc4 net: tlan: Replace in_irq() usage Please repost the wireless stuff for Kalle to linux-wireless@vger, and repost the fsl stuff separately (our patchwork queue is huge, I can't keep this waiting for an ack any longer).