From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
Artemy Kovalyov <artemyko@mellanox.com>,
<linux-rdma@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH rdma-next 0/7] Use only a umem and HW page_shift to calculate MR sizes
Date: Mon, 2 Nov 2020 15:11:35 -0400 [thread overview]
Message-ID: <20201102191135.GA3701319@nvidia.com> (raw)
In-Reply-To: <20201026131936.1335664-1-leon@kernel.org>
On Mon, Oct 26, 2020 at 03:19:29PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> >From Jason:
>
> The MR code computes and passes around a tuple of (npages, page_shift,
> ncont, order) to represent the size of the MR in various terms.
>
> This is quite confusing about what term refers to what, and overlaps with
> data already stored and computed inside the umem. Rework all of this to be
> more umem centric and use these identities instead:
>
> npages == ib_umem_num_pages(mr->umem)
> page_shift == mr->page_shift
> ncont == ib_umem_num_dma_blocks(mr->umem, 1 << mr->page_shift)
> order == order_base_2(ncont)
>
> By storing the page_shift inside the mlx5_ib_mr it becomes nearly self
> describing.
>
> Thanks
>
> Jason Gunthorpe (7):
> RDMA/mlx5: Remove mlx5_ib_mr->order
> RDMA/mlx5: Fix corruption of reg_pages in mlx5_ib_rereg_user_mr()
> RDMA/mlx5: Remove mlx5_ib_mr->npages
> RDMA/mlx5: Move mlx5_ib_cont_pages() to the creation of the mlx5_ib_mr
> RDMA/mlx5: Remove order from mlx5_ib_cont_pages()
> RDMA/mlx5: Remove ncont from mlx5_ib_cont_pages()
> RDMA/mlx5: Remove npages from mlx5_ib_cont_pages()
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-11-02 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 13:19 [PATCH rdma-next 0/7] Use only a umem and HW page_shift to calculate MR sizes Leon Romanovsky
2020-10-26 13:19 ` [PATCH rdma-next 1/7] RDMA/mlx5: Remove mlx5_ib_mr->order Leon Romanovsky
2020-10-26 13:19 ` [PATCH mlx5-next 2/7] RDMA/mlx5: Fix corruption of reg_pages in mlx5_ib_rereg_user_mr() Leon Romanovsky
2020-10-26 13:19 ` [PATCH rdma-next 3/7] RDMA/mlx5: Remove mlx5_ib_mr->npages Leon Romanovsky
2020-10-26 13:19 ` [PATCH rdma-next 4/7] RDMA/mlx5: Move mlx5_ib_cont_pages() to the creation of the mlx5_ib_mr Leon Romanovsky
2020-10-26 13:19 ` [PATCH rdma-next 5/7] RDMA/mlx5: Remove order from mlx5_ib_cont_pages() Leon Romanovsky
2020-10-26 13:19 ` [PATCH rdma-next 6/7] RDMA/mlx5: Remove ncont " Leon Romanovsky
2020-10-26 13:19 ` [PATCH rdma-next 7/7] RDMA/mlx5: Remove npages " Leon Romanovsky
2020-11-02 19:11 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102191135.GA3701319@nvidia.com \
--to=jgg@nvidia.com \
--cc=artemyko@mellanox.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).