From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeedm@nvidia.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Dave Ertman <david.m.ertman@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [pull request][for-next] mlx5-next auxbus support
Date: Sat, 5 Dec 2020 16:19:21 -0800 [thread overview]
Message-ID: <20201205161921.28d5cb7e@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <20201205153545.3d30536b@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
On Sat, 5 Dec 2020 15:35:45 -0800 Jakub Kicinski wrote:
> On Fri, 4 Dec 2020 10:29:52 -0800 Saeed Mahameed wrote:
> > This pull request is targeting net-next and rdma-next branches.
> >
> > This series provides mlx5 support for auxiliary bus devices.
> >
> > It starts with a merge commit of tag 'auxbus-5.11-rc1' from
> > gregkh/driver-core into mlx5-next, then the mlx5 patches that will convert
> > mlx5 ulp devices (netdev, rdma, vdpa) to use the proper auxbus
> > infrastructure instead of the internal mlx5 device and interface management
> > implementation, which Leon is deleting at the end of this patchset.
> >
> > Link: https://lore.kernel.org/alsa-devel/20201026111849.1035786-1-leon@kernel.org/
> >
> > Thanks to everyone for the joint effort !
>
> Pulled, thanks! (I'll push out after build finishes so may be an hour)
Or not, looks like you didn't adjust to Greg's changes:
../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5505:12: error: initialization of ‘void (*)(struct auxiliary_device *)’ from incompatible pointer type ‘int (*)(struct auxiliary_device *)’ [-Werror=incompatible-pointer-types]
5505 | .remove = mlx5e_remove,
| ^~~~~~~~~~~~
../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5505:12: note: (near initialization for ‘mlx5e_driver.remove’)
cc1: some warnings being treated as errors
make[6]: *** [../scripts/Makefile.build:283: drivers/net/ethernet/mellanox/mlx5/core/en_main.o] Error 1
make[5]: *** [../scripts/Makefile.build:500: drivers/net/ethernet/mellanox/mlx5/core] Error 2
make[4]: *** [../scripts/Makefile.build:500: drivers/net/ethernet/mellanox] Error 2
make[3]: *** [../scripts/Makefile.build:500: drivers/net/ethernet] Error 2
make[3]: *** Waiting for unfinished jobs....
next prev parent reply other threads:[~2020-12-06 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 18:29 [pull request][for-next] mlx5-next auxbus support Saeed Mahameed
2020-12-05 0:26 ` Jason Gunthorpe
2020-12-05 23:36 ` Jakub Kicinski
2020-12-05 23:35 ` Jakub Kicinski
2020-12-06 0:19 ` Jakub Kicinski [this message]
2020-12-06 5:03 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205161921.28d5cb7e@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
--to=kuba@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).