From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 862E7C433B4 for ; Mon, 5 Apr 2021 07:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43A0B61278 for ; Mon, 5 Apr 2021 07:44:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232398AbhDEHoq (ORCPT ); Mon, 5 Apr 2021 03:44:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:44322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231523AbhDEHoq (ORCPT ); Mon, 5 Apr 2021 03:44:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 19B1F61279; Mon, 5 Apr 2021 07:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617608680; bh=WdJ6GZIMwNuvuuvXrnwrda5GFONTPH75bo5JtuE/Edg=; h=From:To:Cc:Subject:Date:From; b=ZFcTQZu00/QYtOhBzpdazVnftIqcWeXKE2dhBb9MQmyjXKvFiggxnOOgTr6QIZPBQ DiM/imL5oEI4DzPMg7KKeXxcnN5zBZfEnRYa+FOpmPuL5rnVid78KnBMndVjwcPztm wQy1ZV58z8gmGqhurrUQzGsq+LfKpXLhngsPDe3W6DQDECX7xOxC8qWJoZsDGlvtlO 0Y5bXHFEnsZkeksq+ySFO/JINjJKNw52FGsNjhPR7ZOluktliPVqnZQQk2BbTZNQXm aMaSnqBAQVd7P9XS1+PtgQy7z4yDG037KG0xnDIbBeQ7vC+vHKv+VA+Yr+5rkb1yFR a0aucWmZDMMHg== From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , Dan Carpenter , linux-rdma@vger.kernel.org, Mark Bloch Subject: [PATCH rdma-next] RDMA/addr: Be strict with gid size Date: Mon, 5 Apr 2021 10:44:34 +0300 Message-Id: <20210405074434.264221-1-leon@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Leon Romanovsky The nla_len() is less than or equal to 16. If it's less than 16 then end of the "gid" buffer is uninitialized. Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") Reported-by: Dan Carpenter Signed-off-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/addr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 0abce004a959..65e3e7df8a4b 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -76,7 +76,9 @@ static struct workqueue_struct *addr_wq; static const struct nla_policy ib_nl_addr_policy[LS_NLA_TYPE_MAX] = { [LS_NLA_TYPE_DGID] = {.type = NLA_BINARY, - .len = sizeof(struct rdma_nla_ls_gid)}, + .len = sizeof(struct rdma_nla_ls_gid), + .validation_type = NLA_VALIDATE_MIN, + .min = sizeof(struct rdma_nla_ls_gid)}, }; static inline bool ib_nl_is_good_ip_resp(const struct nlmsghdr *nlh) -- 2.30.2