From: Ira Weiny <ira.weiny@intel.com>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Doug Ledford <dledford@redhat.com>,
Faisal Latif <faisal.latif@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Kamal Heib <kheib@redhat.com>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] RDMA/siw: Convert siw_tx_hdt() to kmap_local_page()
Date: Wed, 23 Jun 2021 08:34:37 -0700 [thread overview]
Message-ID: <20210623153437.GR1905674@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <OF951DAF0B.941A938D-ON002586FD.003F1610-002586FD.00504522@notes.na.collabserv.com>
On Wed, Jun 23, 2021 at 02:36:45PM +0000, Bernard Metzler wrote:
> -----ira.weiny@intel.com wrote: -----
>
> >@@ -506,11 +513,12 @@ static int siw_tx_hdt(struct siw_iwarp_tx
> >*c_tx, struct socket *s)
> > page_array[seg] = p;
> >
> > if (!c_tx->use_sendpage) {
> >- iov[seg].iov_base = kmap(p) + fp_off;
> >- iov[seg].iov_len = plen;
> >+ void *kaddr = kmap_local_page(page_array[seg]);
>
> we can use 'kmap_local_page(p)' here
Yes but I actually did this on purpose as it makes the code read clearly that
the mapping is 'seg' element of the array. Do you prefer 'p' because this is a
performant path?
> >
> > /* Remember for later kunmap() */
> > kmap_mask |= BIT(seg);
> >+ iov[seg].iov_base = kaddr + fp_off;
> >+ iov[seg].iov_len = plen;
> >
> > if (do_crc)
> > crypto_shash_update(
> >@@ -518,7 +526,7 @@ static int siw_tx_hdt(struct siw_iwarp_tx *c_tx,
> >struct socket *s)
> > iov[seg].iov_base,
> > plen);
>
> This patch does not apply for me. Would I have to install first
> your [Patch 3/4] -- since the current patch references kmap_local_page()
> already? Maybe it is better to apply if it would be just one siw
> related patch in that series?
Yes the other patch goes first. I split it out to make this more difficult
change more reviewable. I could squash them as it is probably straight forward
enough but I've been careful with this in other subsystems.
Jason, do you have any issue with squashing the 2 patches?
>
>
>
> > } else if (do_crc) {
> >- kaddr = kmap_local_page(p);
> >+ kaddr = kmap_local_page(page_array[seg]);
>
> using 'kmap_local_page(p)' as you had it is straightforward
> and I would prefer it.
OK. I think this reads cleaner but I can see 'p' being more performant.
>
> > crypto_shash_update(c_tx->mpa_crc_hd,
> > kaddr + fp_off,
> > plen);
> >@@ -542,7 +550,7 @@ static int siw_tx_hdt(struct siw_iwarp_tx *c_tx,
> >struct socket *s)
> >
> > if (++seg > (int)MAX_ARRAY) {
> > siw_dbg_qp(tx_qp(c_tx), "to many fragments\n");
> >- siw_unmap_pages(page_array, kmap_mask);
> >+ siw_unmap_pages(iov, kmap_mask, MAX_ARRAY);
>
> to minimize the iterations over the byte array in 'siw_unmap_pages()',
> we may pass seg-1 instead of MAX_ARRAY
Sounds good.
>
>
> > wqe->processed -= c_tx->bytes_unsent;
> > rv = -EMSGSIZE;
> > goto done_crc;
> >@@ -593,7 +601,7 @@ static int siw_tx_hdt(struct siw_iwarp_tx *c_tx,
> >struct socket *s)
> > } else {
> > rv = kernel_sendmsg(s, &msg, iov, seg + 1,
> > hdr_len + data_len + trl_len);
> >- siw_unmap_pages(page_array, kmap_mask);
> >+ siw_unmap_pages(iov, kmap_mask, MAX_ARRAY);
>
> to minimize the iterations over the byte array in 'siw_unmap_pages()',
> we may pass seg instead of MAX_ARRAY
Will do.
Thanks for the review! :-D
Ira
next prev parent reply other threads:[~2021-06-23 15:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 6:14 [PATCH 0/4] Remove use of kmap() ira.weiny
2021-06-22 6:14 ` [PATCH 1/4] RDMA/hfi1: " ira.weiny
2021-06-24 18:13 ` Jason Gunthorpe
2021-06-22 6:14 ` [PATCH 2/4] RDMA/i40iw: " ira.weiny
2021-06-22 12:14 ` Jason Gunthorpe
2021-06-22 16:56 ` [PATCH V2] RDMA/irdma: " ira.weiny
2021-06-24 18:13 ` Jason Gunthorpe
2021-06-22 6:14 ` [PATCH 3/4] RDMA/siw: Remove kmap() ira.weiny
2021-07-15 18:00 ` Jason Gunthorpe
2021-06-22 6:14 ` [PATCH 4/4] RDMA/siw: Convert siw_tx_hdt() to kmap_local_page() ira.weiny
2021-06-22 20:34 ` [PATCH V2] " ira.weiny
2021-06-23 22:15 ` [PATCH V3] " ira.weiny
2021-06-24 17:48 ` [PATCH V4] " ira.weiny
2021-07-15 18:00 ` Jason Gunthorpe
2021-06-29 14:11 ` Bernard Metzler
2021-06-29 22:13 ` Ira Weiny
2021-06-24 15:45 ` [PATCH V3] " Bernard Metzler
2021-06-24 17:33 ` Ira Weiny
2021-06-23 14:36 ` [PATCH V2] " Bernard Metzler
2021-06-23 15:34 ` Ira Weiny [this message]
2021-06-22 16:42 ` [PATCH 4/4] " Bernard Metzler
2021-06-22 20:39 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623153437.GR1905674@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=BMT@zurich.ibm.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=jgg@ziepe.ca \
--cc=kheib@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).