From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org,
haakon.brugge@oracle.com, yang.jy@fujitsu.com
Subject: Re: [PATCH for-next v2] RDMA/rxe: Fix memory leak in error path code
Date: Thu, 15 Jul 2021 14:56:53 -0300 [thread overview]
Message-ID: <20210715175653.GA663177@nvidia.com> (raw)
In-Reply-To: <20210705164153.17652-1-rpearsonhpe@gmail.com>
On Mon, Jul 05, 2021 at 11:41:54AM -0500, Bob Pearson wrote:
> In rxe_mr_init_user() in rxe_mr.c at the third error the driver fails to
> free the memory at mr->map. This patch adds code to do that.
> This error only occurs if page_address() fails to return a non zero address
> which should never happen for 64 bit architectures.
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Reported by: Haakon Bugge <haakon.bugge@oracle.com>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> Reviewed-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
> v2:
> Left out white space changes.
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2021-07-15 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 16:41 [PATCH for-next v2] RDMA/rxe: Fix memory leak in error path code Bob Pearson
2021-07-06 5:48 ` Zhu Yanjun
2021-07-06 10:10 ` Haakon Bugge
2021-07-15 17:56 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715175653.GA663177@nvidia.com \
--to=jgg@nvidia.com \
--cc=haakon.brugge@oracle.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=yang.jy@fujitsu.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).