From: Jason Gunthorpe <firstname.lastname@example.org>
To: Sagi Grimberg <email@example.com>
Cc: Chesnokov Gleb <Chesnokov.G@raidix.com>,
Subject: Re: [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE
Date: Tue, 27 Jul 2021 14:37:09 -0300 [thread overview]
Message-ID: <20210727173709.GH1721383@nvidia.com> (raw)
On Thu, Jul 22, 2021 at 12:54:26PM -0700, Sagi Grimberg wrote:
> > > > > What is this trying to do anyhow? If the addr has truely changed why
> > > > > does the bind fail?
> > > >
> > > > When the active physical link member of bonding interface in active-standby
> > > > mode gets faulty, the standby link will represent the assigned addresses on
> > > > behalf of the active link.
> > > > Therefore, RDMA communication manager will notify iSER target with
> > > > RDMA_CM_EVENT_ADDR_CHANGE.
> > >
> > > Ah, here is my recollection...
> > >
> > > However I think that if we move that into a work, we should do it
> > > periodically until we succeed or until the endpoint is torn down so
> > > we can handle address removed and restore use-cases.
> > That soudns better, but still I would say this shouldn't even happen
> > in the first place, check the address and don't initiate rebinding if
> > it hasn't changed.
> But don't you need to setup a new cm_id for the this notification? It
> will remain active?
AFAIK the existing listening ID remains, the notification is
informative, it doesn't indicate any CM state has changed.
> Also it's a bit cumbersome to match addresses in some cases like multi
> address interfaces. Almost seems easier to setup a new one...
How so? There is only one address passed to bind. If you create
multiple CM ids to cover all addresses then you need to run a set
algorithm to figure out what cm_ids to destroy and which to
next prev parent reply other threads:[~2021-07-27 17:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 18:26 [PATCH 1/1] iser-target: Fix handling of RDMA_CV_EVENT_ADDR_CHANGE lanevdenoche
2021-07-18 8:50 ` Leon Romanovsky
[not found] ` <firstname.lastname@example.org>
2021-07-19 6:40 ` Leon Romanovsky
2021-07-19 12:13 ` Jason Gunthorpe
2021-07-19 16:07 ` Chesnokov Gleb
2021-07-19 17:09 ` Jason Gunthorpe
2021-07-19 18:27 ` Sagi Grimberg
2021-07-19 18:29 ` Sagi Grimberg
2021-07-19 20:47 ` Chesnokov Gleb
2021-07-22 14:23 ` Jason Gunthorpe
2021-07-22 19:54 ` Sagi Grimberg
2021-07-27 17:37 ` Jason Gunthorpe [this message]
2021-08-06 20:14 ` Sagi Grimberg
2021-08-17 8:30 ` Chesnokov Gleb
2021-08-17 21:27 ` Sagi Grimberg
2021-09-01 11:43 ` Chesnokov Gleb
2021-09-01 11:56 ` Jason Gunthorpe
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).