From: Jason Gunthorpe <jgg@nvidia.com>
To: Prabhakar Kushwaha <pkushwaha@marvell.com>
Cc: linux-rdma@vger.kernel.org, dledford@redhat.com,
mkalderon@marvell.com, davem@davemloft.net, kuba@kernel.org,
smalin@marvell.com, aelior@marvell.com, prabhakar.pkin@gmail.com,
malin1024@gmail.com
Subject: Re: [PATCH for-next] qedr: Move variables reset to qedr_set_common_qp_params()
Date: Thu, 19 Aug 2021 14:28:19 -0300 [thread overview]
Message-ID: <20210819172819.GA354838@nvidia.com> (raw)
In-Reply-To: <20210811051650.14914-1-pkushwaha@marvell.com>
On Wed, Aug 11, 2021 at 08:16:50AM +0300, Prabhakar Kushwaha wrote:
> Qedr code is tightly coupled with existing both INIT transitions.
> Here, during first INIT transition all variables are reset and
> the RESET state is checked in post_recv() before any posting.
>
> Commit dc70f7c3ed34 ("RDMA/cma: Remove unnecessary INIT->INIT
> transition") exposed this bug.
>
> So moving variables reset to qedr_set_common_qp_params() and also
> avoid RESET state check for post_recv().
>
> Signed-off-by: Michal Kalderon <mkalderon@marvell.com>
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Shai Malin <smalin@marvell.com>
> Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
> ---
> drivers/infiniband/hw/qedr/verbs.c | 32 +++++++++++++-----------------
> 1 file changed, 14 insertions(+), 18 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2021-08-19 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 5:16 [PATCH for-next] qedr: Move variables reset to qedr_set_common_qp_params() Prabhakar Kushwaha
2021-08-11 11:44 ` Jason Gunthorpe
2021-08-11 11:50 ` Haakon Bugge
2021-08-12 9:44 ` Prabhakar Kushwaha
2021-08-19 17:28 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819172819.GA354838@nvidia.com \
--to=jgg@nvidia.com \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=malin1024@gmail.com \
--cc=mkalderon@marvell.com \
--cc=pkushwaha@marvell.com \
--cc=prabhakar.pkin@gmail.com \
--cc=smalin@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).