* [PATCH 0/3] RDMA/rxe: Do some cleanup
@ 2021-08-23 9:22 Xiao Yang
2021-08-23 9:22 ` [PATCH 1/3] RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user Xiao Yang
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Xiao Yang @ 2021-08-23 9:22 UTC (permalink / raw)
To: linux-rdma; +Cc: rpearsonhpe, zyjzyj2000, jgg, leon, Xiao Yang
Xiao Yang (3):
RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
RDMA/rxe: Remove the common is_user member of struct rxe_qp
RDMA/rxe: Change the is_user member of struct rxe_cq to bool
drivers/infiniband/sw/rxe/rxe_comp.c | 6 ++--
drivers/infiniband/sw/rxe/rxe_cq.c | 3 +-
drivers/infiniband/sw/rxe/rxe_qp.c | 5 ++--
drivers/infiniband/sw/rxe/rxe_req.c | 4 +--
drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++----
drivers/infiniband/sw/rxe/rxe_verbs.c | 42 +++++++--------------------
drivers/infiniband/sw/rxe/rxe_verbs.h | 3 +-
7 files changed, 25 insertions(+), 48 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
2021-08-23 9:22 [PATCH 0/3] RDMA/rxe: Do some cleanup Xiao Yang
@ 2021-08-23 9:22 ` Xiao Yang
2021-08-23 9:22 ` [PATCH 2/3] RDMA/rxe: Remove the common is_user member of struct rxe_qp Xiao Yang
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Xiao Yang @ 2021-08-23 9:22 UTC (permalink / raw)
To: linux-rdma; +Cc: rpearsonhpe, zyjzyj2000, jgg, leon, Xiao Yang
1) post_one_send() always processes kernel's send queue.
2) rxe_poll_cq() always processes kernel's completion queue.
Fixes: 5bcf5a59c41e ("RDMA/rxe: Protext kernel index from user space")
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_verbs.c | 29 ++++++---------------------
1 file changed, 6 insertions(+), 23 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index c223959ac174..cdded9f64910 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -632,7 +632,6 @@ static int post_one_send(struct rxe_qp *qp, const struct ib_send_wr *ibwr,
struct rxe_sq *sq = &qp->sq;
struct rxe_send_wqe *send_wqe;
unsigned long flags;
- int full;
err = validate_send_wr(qp, ibwr, mask, length);
if (err)
@@ -640,27 +639,16 @@ static int post_one_send(struct rxe_qp *qp, const struct ib_send_wr *ibwr,
spin_lock_irqsave(&qp->sq.sq_lock, flags);
- if (qp->is_user)
- full = queue_full(sq->queue, QUEUE_TYPE_FROM_USER);
- else
- full = queue_full(sq->queue, QUEUE_TYPE_KERNEL);
-
- if (unlikely(full)) {
+ if (unlikely(queue_full(sq->queue, QUEUE_TYPE_KERNEL))) {
spin_unlock_irqrestore(&qp->sq.sq_lock, flags);
return -ENOMEM;
}
- if (qp->is_user)
- send_wqe = producer_addr(sq->queue, QUEUE_TYPE_FROM_USER);
- else
- send_wqe = producer_addr(sq->queue, QUEUE_TYPE_KERNEL);
+ send_wqe = producer_addr(sq->queue, QUEUE_TYPE_KERNEL);
init_send_wqe(qp, ibwr, mask, length, send_wqe);
- if (qp->is_user)
- advance_producer(sq->queue, QUEUE_TYPE_FROM_USER);
- else
- advance_producer(sq->queue, QUEUE_TYPE_KERNEL);
+ advance_producer(sq->queue, QUEUE_TYPE_KERNEL);
spin_unlock_irqrestore(&qp->sq.sq_lock, flags);
@@ -852,18 +840,13 @@ static int rxe_poll_cq(struct ib_cq *ibcq, int num_entries, struct ib_wc *wc)
spin_lock_irqsave(&cq->cq_lock, flags);
for (i = 0; i < num_entries; i++) {
- if (cq->is_user)
- cqe = queue_head(cq->queue, QUEUE_TYPE_TO_USER);
- else
- cqe = queue_head(cq->queue, QUEUE_TYPE_KERNEL);
+ cqe = queue_head(cq->queue, QUEUE_TYPE_KERNEL);
if (!cqe)
break;
memcpy(wc++, &cqe->ibwc, sizeof(*wc));
- if (cq->is_user)
- advance_consumer(cq->queue, QUEUE_TYPE_TO_USER);
- else
- advance_consumer(cq->queue, QUEUE_TYPE_KERNEL);
+
+ advance_consumer(cq->queue, QUEUE_TYPE_KERNEL);
}
spin_unlock_irqrestore(&cq->cq_lock, flags);
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] RDMA/rxe: Remove the common is_user member of struct rxe_qp
2021-08-23 9:22 [PATCH 0/3] RDMA/rxe: Do some cleanup Xiao Yang
2021-08-23 9:22 ` [PATCH 1/3] RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user Xiao Yang
@ 2021-08-23 9:22 ` Xiao Yang
2021-08-23 9:22 ` [PATCH 3/3] RDMA/rxe: Change the is_user member of struct rxe_cq to bool Xiao Yang
2021-08-27 14:25 ` [PATCH 0/3] RDMA/rxe: Do some cleanup Jason Gunthorpe
3 siblings, 0 replies; 7+ messages in thread
From: Xiao Yang @ 2021-08-23 9:22 UTC (permalink / raw)
To: linux-rdma; +Cc: rpearsonhpe, zyjzyj2000, jgg, leon, Xiao Yang
The following commit introduced separate is_user members for struct
rxe_sq/rxe_rq/rxe_srq but no code uses the separate is_user member
of struct rxe_sq and lots of code still use the common is_user member
of struct rxe_qp. So it is clear to make all code use separate is_user
members uniformly and remove the common is_user member.
Fixes: 5bcf5a59c41e ("RDMA/rxe: Protext kernel index from user space")
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_comp.c | 6 +++---
drivers/infiniband/sw/rxe/rxe_qp.c | 5 +++--
drivers/infiniband/sw/rxe/rxe_req.c | 4 ++--
drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++++-----
drivers/infiniband/sw/rxe/rxe_verbs.c | 13 ++++---------
drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
6 files changed, 17 insertions(+), 22 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_comp.c b/drivers/infiniband/sw/rxe/rxe_comp.c
index 58ad9c2644f3..fb7741ec5cd3 100644
--- a/drivers/infiniband/sw/rxe/rxe_comp.c
+++ b/drivers/infiniband/sw/rxe/rxe_comp.c
@@ -142,7 +142,7 @@ static inline enum comp_state get_wqe(struct rxe_qp *qp,
/* we come here whether or not we found a response packet to see if
* there are any posted WQEs
*/
- if (qp->is_user)
+ if (qp->sq.is_user)
wqe = queue_head(qp->sq.queue, QUEUE_TYPE_FROM_USER);
else
wqe = queue_head(qp->sq.queue, QUEUE_TYPE_KERNEL);
@@ -385,7 +385,7 @@ static void make_send_cqe(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
{
memset(cqe, 0, sizeof(*cqe));
- if (!qp->is_user) {
+ if (!qp->sq.is_user) {
struct ib_wc *wc = &cqe->ibwc;
wc->wr_id = wqe->wr.wr_id;
@@ -432,7 +432,7 @@ static void do_complete(struct rxe_qp *qp, struct rxe_send_wqe *wqe)
if (post)
make_send_cqe(qp, wqe, &cqe);
- if (qp->is_user)
+ if (qp->sq.is_user)
advance_consumer(qp->sq.queue, QUEUE_TYPE_FROM_USER);
else
advance_consumer(qp->sq.queue, QUEUE_TYPE_KERNEL);
diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
index 1ab6af7ddb25..cfa04e92286a 100644
--- a/drivers/infiniband/sw/rxe/rxe_qp.c
+++ b/drivers/infiniband/sw/rxe/rxe_qp.c
@@ -248,7 +248,8 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp,
return err;
}
- if (qp->is_user)
+ qp->sq.is_user = uresp ? true : false;
+ if (qp->sq.is_user)
qp->req.wqe_index = producer_index(qp->sq.queue,
QUEUE_TYPE_FROM_USER);
else
@@ -313,7 +314,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp,
spin_lock_init(&qp->rq.producer_lock);
spin_lock_init(&qp->rq.consumer_lock);
- qp->rq.is_user = qp->is_user;
+ qp->rq.is_user = uresp ? true : false;
skb_queue_head_init(&qp->resp_pkts);
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index c57699cc6578..2886709e1823 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -49,7 +49,7 @@ static void req_retry(struct rxe_qp *qp)
unsigned int cons;
unsigned int prod;
- if (qp->is_user) {
+ if (qp->sq.is_user) {
cons = consumer_index(q, QUEUE_TYPE_FROM_USER);
prod = producer_index(q, QUEUE_TYPE_FROM_USER);
} else {
@@ -121,7 +121,7 @@ static struct rxe_send_wqe *req_next_wqe(struct rxe_qp *qp)
unsigned int cons;
unsigned int prod;
- if (qp->is_user) {
+ if (qp->sq.is_user) {
wqe = queue_head(q, QUEUE_TYPE_FROM_USER);
cons = consumer_index(q, QUEUE_TYPE_FROM_USER);
prod = producer_index(q, QUEUE_TYPE_FROM_USER);
diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
index 360ec67cb9e1..71406a49fca3 100644
--- a/drivers/infiniband/sw/rxe/rxe_resp.c
+++ b/drivers/infiniband/sw/rxe/rxe_resp.c
@@ -303,7 +303,7 @@ static enum resp_states get_srq_wqe(struct rxe_qp *qp)
spin_lock_bh(&srq->rq.consumer_lock);
- if (qp->is_user)
+ if (srq->is_user)
wqe = queue_head(q, QUEUE_TYPE_FROM_USER);
else
wqe = queue_head(q, QUEUE_TYPE_KERNEL);
@@ -322,7 +322,7 @@ static enum resp_states get_srq_wqe(struct rxe_qp *qp)
memcpy(&qp->resp.srq_wqe, wqe, size);
qp->resp.wqe = &qp->resp.srq_wqe.wqe;
- if (qp->is_user) {
+ if (srq->is_user) {
advance_consumer(q, QUEUE_TYPE_FROM_USER);
count = queue_count(q, QUEUE_TYPE_FROM_USER);
} else {
@@ -357,7 +357,7 @@ static enum resp_states check_resource(struct rxe_qp *qp,
qp->resp.status = IB_WC_WR_FLUSH_ERR;
return RESPST_COMPLETE;
} else if (!srq) {
- if (qp->is_user)
+ if (qp->rq.is_user)
qp->resp.wqe = queue_head(qp->rq.queue,
QUEUE_TYPE_FROM_USER);
else
@@ -389,7 +389,7 @@ static enum resp_states check_resource(struct rxe_qp *qp,
if (srq)
return get_srq_wqe(qp);
- if (qp->is_user)
+ if (qp->rq.is_user)
qp->resp.wqe = queue_head(qp->rq.queue,
QUEUE_TYPE_FROM_USER);
else
@@ -954,7 +954,7 @@ static enum resp_states do_complete(struct rxe_qp *qp,
/* have copy for srq and reference for !srq */
if (!qp->srq) {
- if (qp->is_user)
+ if (qp->rq.is_user)
advance_consumer(qp->rq.queue, QUEUE_TYPE_FROM_USER);
else
advance_consumer(qp->rq.queue, QUEUE_TYPE_KERNEL);
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index cdded9f64910..4ce4ff6ad80e 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -420,14 +420,9 @@ static struct ib_qp *rxe_create_qp(struct ib_pd *ibpd,
goto err1;
}
- if (udata) {
- if (udata->inlen) {
- err = -EINVAL;
- goto err2;
- }
- qp->is_user = true;
- } else {
- qp->is_user = false;
+ if (udata && udata->inlen) {
+ err = -EINVAL;
+ goto err2;
}
rxe_add_index(qp);
@@ -716,7 +711,7 @@ static int rxe_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr,
return -EINVAL;
}
- if (qp->is_user) {
+ if (qp->sq.is_user) {
/* Utilize process context to do protocol processing */
rxe_run_task(&qp->req.task, 0);
return 0;
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index 959a3260fcab..bb5fb157d073 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -215,7 +215,6 @@ struct rxe_qp {
struct ib_qp_attr attr;
unsigned int valid;
unsigned int mtu;
- bool is_user;
struct rxe_pd *pd;
struct rxe_srq *srq;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] RDMA/rxe: Change the is_user member of struct rxe_cq to bool
2021-08-23 9:22 [PATCH 0/3] RDMA/rxe: Do some cleanup Xiao Yang
2021-08-23 9:22 ` [PATCH 1/3] RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user Xiao Yang
2021-08-23 9:22 ` [PATCH 2/3] RDMA/rxe: Remove the common is_user member of struct rxe_qp Xiao Yang
@ 2021-08-23 9:22 ` Xiao Yang
2021-08-27 14:25 ` [PATCH 0/3] RDMA/rxe: Do some cleanup Jason Gunthorpe
3 siblings, 0 replies; 7+ messages in thread
From: Xiao Yang @ 2021-08-23 9:22 UTC (permalink / raw)
To: linux-rdma; +Cc: rpearsonhpe, zyjzyj2000, jgg, leon, Xiao Yang
Make all is_user members of struct rxe_sq/rxe_cq/rxe_srq/rxe_cq
has the same type.
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_cq.c | 3 +--
drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_cq.c b/drivers/infiniband/sw/rxe/rxe_cq.c
index aef288f164fd..fd655e41d621 100644
--- a/drivers/infiniband/sw/rxe/rxe_cq.c
+++ b/drivers/infiniband/sw/rxe/rxe_cq.c
@@ -81,8 +81,7 @@ int rxe_cq_from_init(struct rxe_dev *rxe, struct rxe_cq *cq, int cqe,
return err;
}
- if (uresp)
- cq->is_user = 1;
+ cq->is_user = uresp ? true : false;
cq->is_dying = false;
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index bb5fb157d073..645eaea564ca 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -64,7 +64,7 @@ struct rxe_cq {
spinlock_t cq_lock;
u8 notify;
bool is_dying;
- int is_user;
+ bool is_user;
struct tasklet_struct comp_task;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] RDMA/rxe: Do some cleanup
2021-08-23 9:22 [PATCH 0/3] RDMA/rxe: Do some cleanup Xiao Yang
` (2 preceding siblings ...)
2021-08-23 9:22 ` [PATCH 3/3] RDMA/rxe: Change the is_user member of struct rxe_cq to bool Xiao Yang
@ 2021-08-27 14:25 ` Jason Gunthorpe
2021-08-30 1:41 ` yangx.jy
3 siblings, 1 reply; 7+ messages in thread
From: Jason Gunthorpe @ 2021-08-27 14:25 UTC (permalink / raw)
To: Xiao Yang; +Cc: linux-rdma, rpearsonhpe, zyjzyj2000, leon
On Mon, Aug 23, 2021 at 05:22:53PM +0800, Xiao Yang wrote:
> Xiao Yang (3):
> RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
> RDMA/rxe: Remove the common is_user member of struct rxe_qp
> RDMA/rxe: Change the is_user member of struct rxe_cq to bool
>
> drivers/infiniband/sw/rxe/rxe_comp.c | 6 ++--
> drivers/infiniband/sw/rxe/rxe_cq.c | 3 +-
> drivers/infiniband/sw/rxe/rxe_qp.c | 5 ++--
> drivers/infiniband/sw/rxe/rxe_req.c | 4 +--
> drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++----
> drivers/infiniband/sw/rxe/rxe_verbs.c | 42 +++++++--------------------
> drivers/infiniband/sw/rxe/rxe_verbs.h | 3 +-
> 7 files changed, 25 insertions(+), 48 deletions(-)
This will have to wait until v5.15-rc1
Jason
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] RDMA/rxe: Do some cleanup
2021-08-27 14:25 ` [PATCH 0/3] RDMA/rxe: Do some cleanup Jason Gunthorpe
@ 2021-08-30 1:41 ` yangx.jy
0 siblings, 0 replies; 7+ messages in thread
From: yangx.jy @ 2021-08-30 1:41 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma, rpearsonhpe, zyjzyj2000, leon
On 2021/8/27 22:25, Jason Gunthorpe wrote:
> On Mon, Aug 23, 2021 at 05:22:53PM +0800, Xiao Yang wrote:
>> Xiao Yang (3):
>> RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
>> RDMA/rxe: Remove the common is_user member of struct rxe_qp
>> RDMA/rxe: Change the is_user member of struct rxe_cq to bool
>>
>> drivers/infiniband/sw/rxe/rxe_comp.c | 6 ++--
>> drivers/infiniband/sw/rxe/rxe_cq.c | 3 +-
>> drivers/infiniband/sw/rxe/rxe_qp.c | 5 ++--
>> drivers/infiniband/sw/rxe/rxe_req.c | 4 +--
>> drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++----
>> drivers/infiniband/sw/rxe/rxe_verbs.c | 42 +++++++--------------------
>> drivers/infiniband/sw/rxe/rxe_verbs.h | 3 +-
>> 7 files changed, 25 insertions(+), 48 deletions(-)
> This will have to wait until v5.15-rc1
>
> Jason
Hi Jason,
It is fine to me. Thanks for your remind.
Best Regards,
Xiao Yang
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/3] RDMA/rxe: Do some cleanup
@ 2021-08-23 9:08 Xiao Yang
0 siblings, 0 replies; 7+ messages in thread
From: Xiao Yang @ 2021-08-23 9:08 UTC (permalink / raw)
To: linux-rdma; +Cc: rpearsonhpe, zyjzyj2000, jgg, leon, Xiao Yang
Xiao Yang (3):
RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
RDMA/rxe: Remove the common is_user member of struct rxe_qp
RDMA/rxe: Change the is_user member of struct rxe_cq to bool
drivers/infiniband/sw/rxe/rxe_comp.c | 6 ++--
drivers/infiniband/sw/rxe/rxe_cq.c | 3 +-
drivers/infiniband/sw/rxe/rxe_qp.c | 5 ++--
drivers/infiniband/sw/rxe/rxe_req.c | 4 +--
drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++----
drivers/infiniband/sw/rxe/rxe_verbs.c | 42 +++++++--------------------
drivers/infiniband/sw/rxe/rxe_verbs.h | 3 +-
7 files changed, 25 insertions(+), 48 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-30 1:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 9:22 [PATCH 0/3] RDMA/rxe: Do some cleanup Xiao Yang
2021-08-23 9:22 ` [PATCH 1/3] RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user Xiao Yang
2021-08-23 9:22 ` [PATCH 2/3] RDMA/rxe: Remove the common is_user member of struct rxe_qp Xiao Yang
2021-08-23 9:22 ` [PATCH 3/3] RDMA/rxe: Change the is_user member of struct rxe_cq to bool Xiao Yang
2021-08-27 14:25 ` [PATCH 0/3] RDMA/rxe: Do some cleanup Jason Gunthorpe
2021-08-30 1:41 ` yangx.jy
-- strict thread matches above, loose matches on Subject: below --
2021-08-23 9:08 Xiao Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).