From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Shai Malin <smalin@marvell.com>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
aelior@marvell.com, malin1024@gmail.com,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] qed: Enable RDMA relaxed ordering
Date: Mon, 23 Aug 2021 10:33:40 -0300 [thread overview]
Message-ID: <20210823133340.GC543798@ziepe.ca> (raw)
In-Reply-To: <YSOL9TNeLy3uHma6@unreal>
On Mon, Aug 23, 2021 at 02:52:21PM +0300, Leon Romanovsky wrote:
> +RDMA
>
> Jakub, David
>
> Can we please ask that everything directly or indirectly related to RDMA
> will be sent to linux-rdma@ too?
>
> On Sun, Aug 22, 2021 at 09:54:48PM +0300, Shai Malin wrote:
> > Enable the RoCE and iWARP FW relaxed ordering.
> >
> > Signed-off-by: Ariel Elior <aelior@marvell.com>
> > Signed-off-by: Shai Malin <smalin@marvell.com>
> > drivers/net/ethernet/qlogic/qed/qed_rdma.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> > index 4f4b79250a2b..496092655f26 100644
> > +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> > @@ -643,6 +643,8 @@ static int qed_rdma_start_fw(struct qed_hwfn *p_hwfn,
> > cnq_id);
> > }
> >
> > + p_params_header->relaxed_ordering = 1;
>
> Maybe it is only description that needs to be updated, but I would
> expect to see call to pcie_relaxed_ordering_enabled() before setting
> relaxed_ordering to always true.
>
> If we are talking about RDMA, the IB_ACCESS_RELAXED_ORDERING flag should
> be taken into account too.
Why does this file even exist in netdev? This whole struct
qed_rdma_ops mess looks like another mis-design to support out of tree
modules??
Jason
next prev parent reply other threads:[~2021-08-23 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210822185448.12053-1-smalin@marvell.com>
2021-08-23 11:52 ` [PATCH] qed: Enable RDMA relaxed ordering Leon Romanovsky
2021-08-23 13:33 ` Jason Gunthorpe [this message]
2021-08-23 14:54 ` [EXT] " Ariel Elior
2021-08-23 15:17 ` Jason Gunthorpe
2021-08-24 12:24 ` Leon Romanovsky
2021-08-24 19:16 ` Ariel Elior
2021-08-24 19:42 ` Jason Gunthorpe
2021-08-25 9:35 ` Ariel Elior
2021-08-26 12:05 Shai Malin
2021-08-26 13:06 ` Jason Gunthorpe
2021-08-26 13:40 Shai Malin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823133340.GC543798@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=malin1024@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=smalin@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).