From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: blktest/rxe almost working
Date: Thu, 2 Sep 2021 20:38:53 -0300 [thread overview]
Message-ID: <20210902233853.GB2505917@nvidia.com> (raw)
In-Reply-To: <c7557529-d07d-3e35-0f03-2bbe867af4a1@gmail.com>
On Thu, Sep 02, 2021 at 04:41:15PM -0500, Bob Pearson wrote:
> Now that for-next is on 5.14.0-rc6+ blktest srp/002 is very close to
> working for rxe but there is still one error. After adding MW
> support I added a test to local invalidate to check and see if the
> l/rkey matched the key actually contained in the MR/MW when local
> invalidate is called. This is failing for srp/002 with the key
> portion of the rkey off by one. Looking at ib_srp.c I see code that
> does in fact increment the rkey by one and also has code that posts
> a local invalidate. This was never checked before and is now failing
> to match. If I mask off the key portion in the test the whole test
> case passes so the other problems appear to have been fixed. If the
> increment and invalidate are out of sync this could result in the
> error. I suspect this may be a bug in srp. Worst case I can remove
> this test but I would rather not.
I didn't check the spec, but since SRP works with HW devices I wonder
if invalidation is supposed to ignore the variant bits in the mkey?
Jason
next prev parent reply other threads:[~2021-09-02 23:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 21:41 blktest/rxe almost working Bob Pearson
2021-09-02 23:38 ` Jason Gunthorpe [this message]
2021-09-03 22:18 ` Bob Pearson
2021-09-03 23:13 ` Bart Van Assche
2021-09-04 22:30 ` Jason Gunthorpe
2021-09-05 18:02 ` Bob Pearson
2021-09-07 12:01 ` Jason Gunthorpe
2021-09-07 16:35 ` Bob Pearson
2021-09-07 16:39 ` Jason Gunthorpe
2021-09-07 16:47 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902233853.GB2505917@nvidia.com \
--to=jgg@nvidia.com \
--cc=bvanassche@acm.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).