archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <>
To: Len Baker <>
Cc: Selvin Xavier <>,
	Naresh Kumar PBS <>,
	Doug Ledford <>,
	Kees Cook <>,,,
Subject: Re: [PATCH] RDMA/bnxt_re: Prefer kcalloc over open coded arithmetic
Date: Wed, 8 Sep 2021 08:44:40 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Sep 05, 2021 at 10:18:12AM +0200, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> In this case this is not actually dynamic sizes: both sides of the
> multiplication are constant values. However it is best to refactor this
> anyway, just to keep the open-coded math idiom out of code.
> So, use the purpose specific kcalloc() function instead of the argument
> size * count in the kzalloc() function.
> Also, remove the unnecessary initialization of the sqp_tbl variable
> since it is set a few lines later.
> [1]
> Signed-off-by: Len Baker <>
> Reviewed-by: Leon Romanovsky <>
> Acked-by: Selvin Xavier <>
> ---
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-rc, thanks


      parent reply	other threads:[~2021-09-08 11:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-05  8:18 [PATCH] RDMA/bnxt_re: Prefer kcalloc over open coded arithmetic Len Baker
2021-09-05 10:21 ` Leon Romanovsky
2021-09-07 14:12   ` Selvin Xavier
2021-09-08 11:44 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).