linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Prabhakar Kushwaha <pkushwaha@marvell.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<linux-rdma@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<martin.petersen@oracle.com>, <aelior@marvell.com>,
	<smalin@marvell.com>, <jhasan@marvell.com>,
	<mrangankar@marvell.com>, <prabhakar.pkin@gmail.com>,
	<malin1024@gmail.com>, Omkar Kulkarni <okulkarni@marvell.com>
Subject: Re: [PATCH 04/12] qed: Update qed_mfw_hsi.h for FW ver 8.59.1.0
Date: Wed, 29 Sep 2021 11:38:17 -0700	[thread overview]
Message-ID: <20210929113817.06da736a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210929121215.17864-5-pkushwaha@marvell.com>

On Wed, 29 Sep 2021 15:12:07 +0300 Prabhakar Kushwaha wrote:
> The qed_mfw_hsi.h contains HSI (Hardware Software Interface) changes
> related to management firmware. It has been updated to support new FW
> version 8.59.1.0 with below changes.
>  - New defines for VF bitmap.
>  - fec_mode and extended_speed defines updated in struct eth_phy_cfg.
>  - Updated structutres lldp_system_tlvs_buffer_s, public_global,
>    public_port, public_func, drv_union_data, public_drv_mb
>    with all dependent new structures.
>  - Updates in NVM related structures and defines.
>  - Msg defines are added in enum drv_msg_code and fw_msg_code.
>  - Updated/added new defines.
> 
> This patch also fixes the existing checkpatch warnings and few important
> checks.
> 
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Omkar Kulkarni <okulkarni@marvell.com>
> Signed-off-by: Shai Malin <smalin@marvell.com>
> Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>

drivers/net/ethernet/qlogic/qed/qed_main.c:102:18: warning: ‘qed_mfw_ext_20g’ defined but not used [-Wunused-const-variable=]
  102 | static const u32 qed_mfw_ext_20g[] __initconst = {
      |                  ^~~~~~~~~~~~~~~


Plus you add a whole bunch on kdoc warnings with those patches.
Please make sure no new kdoc warnings and no new compilation warnings
(with C=1 W=1 flags!)

  reply	other threads:[~2021-09-29 18:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 12:12 [PATCH 00/12] qed: new firmware version 8.59.1.0 support Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 01/12] qed: Remove e4_ and _e4 from FW HSI Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 02/12] qed: Split huge qed_hsi.h header file Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 03/12] qed: Update common_hsi for FW ver 8.59.1.0 Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 04/12] qed: Update qed_mfw_hsi.h " Prabhakar Kushwaha
2021-09-29 18:38   ` Jakub Kicinski [this message]
2021-09-30 10:18     ` [EXT] " Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 05/12] qed: Update qed_hsi.h for fw 8.59.1.0 Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 06/12] qed: Use enum as per FW 8.59.1.0 in qed_iro_hsi.h Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 07/12] qed: Update FW init functions to support FW 8.59.1.0 Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 08/12] qed: Add '_GTT' suffix to the IRO RAM macros Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 09/12] qed: Update debug related changes Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 10/12] qed: Update TCP silly-window-syndrome timeout for iwarp, scsi Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 11/12] qed: Update the TCP active termination 2 MSL timer ("TIME_WAIT") Prabhakar Kushwaha
2021-09-29 12:12 ` [PATCH 12/12] qed: fix ll2 establishment during load of RDMA driver Prabhakar Kushwaha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929113817.06da736a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=jhasan@marvell.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=malin1024@gmail.com \
    --cc=martin.petersen@oracle.com \
    --cc=mrangankar@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=okulkarni@marvell.com \
    --cc=pkushwaha@marvell.com \
    --cc=prabhakar.pkin@gmail.com \
    --cc=smalin@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).