From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: dledford@redhat.com, jgg@nvidia.com, linux-rdma@vger.kernel.org,
saeedm@nvidia.com
Subject: Re: [PATCH rdma-next 2/3] mlx5: use dev_addr_mod()
Date: Thu, 21 Oct 2021 05:58:23 -0700 [thread overview]
Message-ID: <20211021055823.2319a4c8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YXE3wblxcVY/1siJ@unreal>
On Thu, 21 Oct 2021 12:49:53 +0300 Leon Romanovsky wrote:
> > - dev->dev_addr[1] = (ipriv->qpn >> 16) & 0xff;
^ the original modifies starting at offset 1
> > - dev->dev_addr[2] = (ipriv->qpn >> 8) & 0xff;
> > - dev->dev_addr[3] = (ipriv->qpn) & 0xff;
> > + addr_mod[0] = (ipriv->qpn >> 16) & 0xff;
> > + addr_mod[1] = (ipriv->qpn >> 8) & 0xff;
> > + addr_mod[2] = (ipriv->qpn) & 0xff;
> > + dev_addr_mod(dev, 1, addr_mod, sizeof(addr_mod));
> ^^^ It should be 0, no?
next prev parent reply other threads:[~2021-10-21 12:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 18:26 [PATCH rdma-next 0/3] rdma: prepare for const netdev->dev_addr Jakub Kicinski
2021-10-19 18:26 ` [PATCH rdma-next 1/3] ipoib: use dev_addr_mod() Jakub Kicinski
2021-10-21 9:51 ` Leon Romanovsky
2021-10-19 18:26 ` [PATCH rdma-next 2/3] mlx5: " Jakub Kicinski
2021-10-21 9:49 ` Leon Romanovsky
2021-10-21 12:58 ` Jakub Kicinski [this message]
2021-10-21 13:40 ` Leon Romanovsky
2021-10-21 13:40 ` Leon Romanovsky
2021-10-19 18:26 ` [PATCH rdma-next 3/3] RDMA: constify netdev->dev_addr accesses Jakub Kicinski
2021-10-21 9:51 ` Leon Romanovsky
2021-10-21 11:48 ` Dennis Dalessandro
2021-10-25 17:36 ` [PATCH rdma-next 0/3] rdma: prepare for const netdev->dev_addr Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021055823.2319a4c8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).