From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABE8C43217 for ; Mon, 25 Oct 2021 21:21:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7AB260C51 for ; Mon, 25 Oct 2021 21:21:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235165AbhJYVXv (ORCPT ); Mon, 25 Oct 2021 17:23:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231959AbhJYVXu (ORCPT ); Mon, 25 Oct 2021 17:23:50 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF60C061220 for ; Mon, 25 Oct 2021 14:21:27 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id m14so12171204pfc.9 for ; Mon, 25 Oct 2021 14:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Dg+3da77xCN0ept3lU6Adg5MAj44I6g+k6oh+Yv/Wmk=; b=ZZAE5vvBlXBqmnqPeVDMpzNlRMG4f8aUTMM11B3Wt0yaKexrHt55FQmO5u1fD7bidR 02xhl5QvTcmR3cGt0oq36GHl7u+9soV9E6KhT6dXaK6gGrqfTsgCADyJ2v6e5SSMny1K kHJTuEDYeo3h4PCPdtNNG1VGr+EIBO7xWhzuo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Dg+3da77xCN0ept3lU6Adg5MAj44I6g+k6oh+Yv/Wmk=; b=FbZM04kOy92cNLjaKTpXQNWjZJYB/KqK/qxDLcOqQPgvA5k9bgKTHJRGgEYh8KrY4C 6FqTduNYZoTUyanyfUZ1y7LFbd6cPcXjwInWXdSi98zb8+18RxDnqWCthkG4FLq2Vusz VPFSOK+GzqckQRrazxyGme0JoUprksX2Dc3oI7L/uL1oSgncVffVwL2IYtu2Km0VjHNs vW5n2+OCCLApRhslNXuToN+5a6C2ta4pNtVUmvH0EArzdXQdTEkcB5Fd2/Z4DApLI7rb W1fk5WXk2KfSDDR/AO2uI3dfUQPtK98sI710r8Tac5ps5SfMAqSmYKWv1zGXluzI4ypX upYw== X-Gm-Message-State: AOAM533MlG90b7RBQU14k9YCpPfpm3SkDbe97g6x+/l5VBj2LmaHPlfY H/MUIwFaMUSRY6opuzP9oZvF1w== X-Google-Smtp-Source: ABdhPJwuFvhpOg9qcPmPW8fWT61xDymkszr5XQdULAP3e/U/Jqkxh9G7sdKWk3bNge4o+fhW5E7j4Q== X-Received: by 2002:a63:7c52:: with SMTP id l18mr9384968pgn.112.1635196887256; Mon, 25 Oct 2021 14:21:27 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j3sm20621719pfu.218.2021.10.25.14.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 14:21:26 -0700 (PDT) Date: Mon, 25 Oct 2021 14:21:26 -0700 From: Kees Cook To: Yafang Shao Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, pmladek@suse.com, peterz@infradead.org, viro@zeniv.linux.org.uk, valentin.schneider@arm.com, qiang.zhang@windriver.com, robdclark@chromium.org, christian@brauner.io, dietmar.eggemann@arm.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Andrii Nakryiko Subject: Re: [PATCH v6 07/12] samples/bpf/offwaketime_kern: make sched_switch tracepoint args adopt to comm size change Message-ID: <202110251421.0CD56F8@keescook> References: <20211025083315.4752-1-laoar.shao@gmail.com> <20211025083315.4752-8-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211025083315.4752-8-laoar.shao@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Oct 25, 2021 at 08:33:10AM +0000, Yafang Shao wrote: > The sched:sched_switch tracepoint is derived from kernel, we should make > its args compitable with the kernel. > > Signed-off-by: Yafang Shao > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Andrii Nakryiko > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- > samples/bpf/offwaketime_kern.c | 4 ++-- Seems this should be merged with the prior bpf samples patch? -Kees > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/samples/bpf/offwaketime_kern.c b/samples/bpf/offwaketime_kern.c > index 4866afd054da..eb4d94742e6b 100644 > --- a/samples/bpf/offwaketime_kern.c > +++ b/samples/bpf/offwaketime_kern.c > @@ -113,11 +113,11 @@ static inline int update_counts(void *ctx, u32 pid, u64 delta) > /* taken from /sys/kernel/debug/tracing/events/sched/sched_switch/format */ > struct sched_switch_args { > unsigned long long pad; > - char prev_comm[16]; > + char prev_comm[TASK_COMM_LEN]; > int prev_pid; > int prev_prio; > long long prev_state; > - char next_comm[16]; > + char next_comm[TASK_COMM_LEN]; > int next_pid; > int next_prio; > }; > -- > 2.17.1 > -- Kees Cook